Skip to content

Document principles - #50

Merged
broccolini merged 2 commits into
masterfrom
brocs/principles
Dec 7, 2018
Merged

Document principles#50
broccolini merged 2 commits into
masterfrom
brocs/principles

Conversation

@broccolini

@broccolini broccolini commented Jun 1, 2018

Copy link
Copy Markdown
Contributor

This is a WIP. We started the discussion in a google doc, starting to flesh out into more memorable and concise sections.

@primer/ds-core This is definitely not finished but please comment or suggest additions etc. as this should be a collaborative effort!

👀 Rendered

Comment thread principles.md Outdated
* Choose language that provides mutual understanding between engineering and design over specificity.
* Support new vocabulary with descriptions and examples.
* Be consistent in the application of vocabulary in written and verbal communication to reinforce understandings.
* Articulate what you're are trying to do as well as what you are not doing.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strike 're here (you're areyou are).

Comment thread principles.md Outdated

### Innovation

* Treat everything as an experiment. Make small incremental steps steps that provide proof towards goals, or disprove them.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strike the duplicate steps here.

Comment thread principles.md Outdated
* Seek feedback on implementations as often as possible.
* Everything is a component.
* Provide flexibility, but within the boundaries of the system.
* Assume that people will break the rules, provide safe ways for them to do so.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this one a lot. We should either add an and before provide here or change the comma to a semicolon.

Comment thread principles.md
@@ -0,0 +1,39 @@
# Principles

### Communication

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also add a point here about writing code that is easy to read, as IMO that also falls under both internal and external communication. Something like "Whenever possible, write easily readable code. Readable code speeds up the development process and enables us to work smoothly with other teams.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was thinking that would be better covered in Implementation but open to suggestions!

Comment thread principles.md
* Make decisions based on long term goals rather than this week's ship.
* Evaluate technology by the risk they present, not just the solution they offer. High risk deserves careful consideration, low risk deserves less attention.
* Have opinions and arguments for them, but remain open to seeing and hearing evidence that clashes with them when those opinions become wrong.
* Prioritize solutions for people who use the system and how it serves the customers who use products built with the system.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@broccolini

Copy link
Copy Markdown
Contributor Author

I'm going to merge this once I have the 👍 - we can continue to iterate, and long term I think part of this can be pulled out into global operating principles for working on all Primer projects.

@broccolini broccolini changed the title [wip] Document principles Document principles Dec 7, 2018

@emplums emplums left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@broccolini
broccolini merged commit 1a39887 into master Dec 7, 2018
@broccolini
broccolini deleted the brocs/principles branch December 7, 2018 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants