Uh oh!
There was an error while loading. Please reload this page.
Add bg prop to ProgressBar.Item - #5007
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 2ef06ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lukasoppermann added a commit
to primer/eslint-plugin-primer-react
that referenced
this pull request
Sep 23, 2024
Merge this once primer/react#5007 is merged
lukasoppermanntemporarily deployed
to
github-pages
September 23, 2024 07:34 — with 
GitHub Actions
Inactive
lukasoppermannforce-pushed
the
@lukasoppermann/progressbar
branch
from
September 23, 2024 07:37
71530f0 to
09c95e3Comparelukasoppermanntemporarily deployed
to
github-pages
September 23, 2024 07:39 — with GitHub Actions
Inactive
Contributor
size-limit report 📦
|
lukasoppermannforce-pushed
the
@lukasoppermann/progressbar
branch
from
September 23, 2024 07:49
09c95e3 to
623c2deComparelukasoppermanntemporarily deployed
to
github-pages
September 23, 2024 07:50 — with GitHub Actions
Inactive
lukasoppermannforce-pushed
the
@lukasoppermann/progressbar
branch
from
September 23, 2024 08:29
623c2de to
0a88699Comparelukasoppermanntemporarily deployed
to
github-pages
September 23, 2024 08:31 — with GitHub Actions
Inactive
lukasoppermann
enabled auto-merge
September 23, 2024 08:58
lukasoppermann added a commit
to primer/eslint-plugin-primer-react
that referenced
this pull request
Sep 23, 2024
* Add bg for ProgressBar.item Merge this once primer/react#5007 is merged * Create beige-schools-horse.md
siddharthkp
requested changes
Sep 23, 2024
siddharthkp
left a comment
Member
There was a problem hiding this comment.
Request some minor improvements
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
lukasoppermanntemporarily deployed
to
github-pages
September 23, 2024 14:04 — with GitHub Actions
Inactive
| if (args.bg && args.bg !== '') { | ||
| setSectionColors([args.bg, ...sectionColorsDefault]) | ||
| } | ||
| }, [args.bg]) |
Member
There was a problem hiding this comment.
(non blocker, nit picking) Didn't really understand what this block of code does, can you help me?
ContributorAuthor
There was a problem hiding this comment.
Needed to avoid error: "To many re-renders"
siddharthkp
approved these changes
Sep 24, 2024
Merged
WilliamSmith1226 added a commit
to WilliamSmith1226/React-eslint-plugin-primer-components
that referenced
this pull request
Jan 6, 2026
* Add bg for ProgressBar.item Merge this once primer/react#5007 is merged * Create beige-schools-horse.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
bgprop for onProgressBar.Itemas discussed in https://github.slack.com/archives/GACAW0NPM/p1726839001767409Follow-up task
Changelog
bgprop for onProgressBar.ItemRollout strategy
Testing & Reviewing
Merge checklist