Skip to content

chore(deps): update @playwright/test to 1.47.2 - #5016

Merged
joshblack merged 5 commits into
mainfrom
chore/update-playwright-to-1.47.2
Oct 10, 2024
Merged

chore(deps): update @playwright/test to 1.47.2#5016
joshblack merged 5 commits into
mainfrom
chore/update-playwright-to-1.47.2

Conversation

@joshblack

@joshblackjoshblack commented Sep 24, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Update our dependency on @playwright/test to latest

Changelog

New

Changed

  • Update @playwright/test to 1.47.2 in package.json
  • Update actions to use 1.47.2 docker image

Removed

Rollout strategy

  • None; if selected, include a brief description as to why

@changeset-bot

changeset-botBot commented Sep 24, 2024•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: cef9624

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblackjoshblack added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 24, 2024
@github-actionsgithub-actionsBot added the staff Author is a staff member label Sep 24, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5016 September 24, 2024 17:01 Inactive
@github-actions

github-actionsBot commented Sep 24, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js96.88 KB (0%)
packages/react/dist/browser.umd.js97.28 KB (0%)

@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 24, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5016 September 24, 2024 17:10 Inactive
@joshblackjoshblack added the skip changeset This change does not need a changelog label Sep 24, 2024
@joshblack
joshblack marked this pull request as ready for review September 25, 2024 15:36
@joshblack
joshblack requested review from a team as code ownersSeptember 25, 2024 15:36
broccolinisoup
broccolinisoup approved these changes Sep 27, 2024
View reviewed changes

@broccolinisoupbroccolinisoup left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question but looking good!

Comment thread....test.ts-snapshots/SelectPanel-Default-forced-colors-dark-modern-action-list--true-linux.png

@broccolinisoupbroccolinisoupSep 27, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the marked checkboxes in the before screenshot were empty 🤔 And I think the before one uses modern action list (the ff flag is on?). I think the added screenshot is the expected one though. I don't know, I am confused 😅

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5016 October 7, 2024 16:47 Inactive
@joshblackjoshblack added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 7, 2024
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 7, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5016 October 7, 2024 17:50 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5016 October 10, 2024 15:01 Inactive
@joshblack
joshblack added this pull request to the merge queueOct 10, 2024
Merged via the queue into main with commit a8cc373Oct 10, 2024
@joshblack
joshblack deleted the chore/update-playwright-to-1.47.2 branch October 10, 2024 15:19
joshblack added a commit that referenced this pull request Oct 10, 2024
@joshblack
Revert "chore(deps): update @playwright/test to 1.47.2 (#5016)"
a209540
This reverts commit a8cc373.
@joshblackjoshblack mentioned this pull request Oct 10, 2024
Closed
@TylerJDevTylerJDev mentioned this pull request Nov 21, 2024
Merged
13 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@broccolinisoupbroccolinisoupbroccolinisoup approved these changes
@mperrottimperrottiAwaiting requested review from mperrottimperrotti was automatically assigned from primer/design-reviewers

Assignees

No one assigned

Labels

skip changesetThis change does not need a changelogstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joshblack@broccolinisoup