Uh oh!
There was an error while loading. Please reload this page.
Use the IconButton for the close button on Dialog - #5066
Merged
Conversation
🦋 Changeset detectedLatest commit: 38d89ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
joshblack
approved these changes
Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue when the feature flag is enabled for CSS module buttons the close button looses it's hover state. I fixed this issue by removing the styled component
DialogCloseButtonand usedIconButtoninstead. The only downside is I needed to useunsafeDisableTooltipto remove the Tooltip like the existing functionality. If we want to remove this we should talk to design about allowing a tooltip here.Changelog
Changed
DialogCloseButtonis using IconButton directlyRollout strategy
Testing & Reviewing
Visit the storybook story for Dialog and toggle the
primer_react_css_modules_stafffeature flag on. Then hover over the close x.Merge checklist