Skip to content

SelectPanel: Fix items not being selected when defined within scope - #5073

Merged
siddharthkp merged 4 commits into
mainfrom
selectpanel-track-by-id
Oct 8, 2024
Merged

SelectPanel: Fix items not being selected when defined within scope#5073
siddharthkp merged 4 commits into
mainfrom
selectpanel-track-by-id

Conversation

@siddharthkp

@siddharthkpsiddharthkp commented Oct 7, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot

changeset-botBot commented Oct 7, 2024•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: faf8056

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siddharthkpsiddharthkp self-assigned this Oct 7, 2024
@siddharthkpsiddharthkp added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 7, 2024
@github-actionsgithub-actionsBot added the staff Author is a staff member label Oct 7, 2024
@siddharthkpsiddharthkp changed the title Selectpanel track bySelectPanel: Track selection by item.idOct 7, 2024
@github-actions

github-actionsBot commented Oct 7, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js96.72 KB (+0.02% 🔺)
packages/react/dist/browser.umd.js97.01 KB (-0.01% 🔽)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5073 October 7, 2024 11:05 Inactive
@primer-integration

primer-integrationBot commented Oct 7, 2024

Copy link
Copy Markdown

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/345814

@primer-integration

primer-integrationBot commented Oct 7, 2024

Copy link
Copy Markdown

🟢 golden-jobs completed with status success.

@siddharthkp
siddharthkp marked this pull request as ready for review October 7, 2024 12:56
@siddharthkp
siddharthkp requested a review from a team as a code ownerOctober 7, 2024 12:56
@siddharthkpsiddharthkp added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 7, 2024
@siddharthkpsiddharthkp changed the title SelectPanel: Track selection by item.idSelectPanel: Fix items not being selected when defined within scopeOct 7, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5073 October 7, 2024 23:14 Inactive
broccolinisoup
broccolinisoup approved these changes Oct 8, 2024
View reviewed changes
Comment threadpackages/react/src/SelectPanel/SelectPanel.tsx
@siddharthkp
siddharthkp added this pull request to the merge queueOct 8, 2024
Merged via the queue into main with commit 472967aOct 8, 2024
@siddharthkp
siddharthkp deleted the selectpanel-track-by-id branch October 8, 2024 14:21
@primerprimerBot mentioned this pull request Oct 8, 2024
Merged
@siddharthkpsiddharthkp mentioned this pull request Oct 8, 2024
Closed
13 tasks
@primerprimerBot mentioned this pull request Oct 18, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@broccolinisoupbroccolinisoupbroccolinisoup approved these changes

Assignees

@siddharthkpsiddharthkp

Labels

integration-tests: passingChanges in this PR do NOT cause breaking changes in gh/ghstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SelectPanel should compare Objects based on key or id instead of the Objects themselves

3 participants

@siddharthkp@broccolinisoup@jonrohan