Skip to content

revert: set global focus styles - #5114

Merged
broccolinisoup merged 1 commit into
mainfrom
chore/revert-segmented-control
Oct 13, 2024
Merged

revert: set global focus styles#5114
broccolinisoup merged 1 commit into
mainfrom
chore/revert-segmented-control

Conversation

@joshblack

@joshblackjoshblack commented Oct 11, 2024

Copy link
Copy Markdown
Member

@joshblack
joshblack requested a review from a team as a code ownerOctober 11, 2024 16:37
@changeset-bot

changeset-botBot commented Oct 11, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8c7ae00

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblackjoshblack added the skip changeset This change does not need a changelog label Oct 11, 2024
@github-actionsgithub-actionsBot added the staff Author is a staff member label Oct 11, 2024
@github-actions

github-actionsBot commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 11, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5114 October 11, 2024 16:40 Inactive
@github-actions

github-actionsBot commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js97.68 KB (+0.08% 🔺)
packages/react/dist/browser.umd.js97.81 KB (+0.02% 🔺)

@broccolinisoup
broccolinisoup added this pull request to the merge queueOct 13, 2024
Merged via the queue into main with commit 9f37707Oct 13, 2024
@broccolinisoup
broccolinisoup deleted the chore/revert-segmented-control branch October 13, 2024 22:02
@francinelucca

francinelucca commented Oct 16, 2024

Copy link
Copy Markdown
Member

Thanks for doing this 🙏🏼

francinelucca added a commit that referenced this pull request Oct 17, 2024
@francinelucca
Revert "revert: set global focus styles (#5114)"
7f6b50b
This reverts commit 9f37707.
@francineluccafrancinelucca mentioned this pull request Oct 17, 2024
Merged
13 tasks
github-merge-queueBot pushed a commit that referenced this pull request Oct 22, 2024
@francinelucca
fix(SegmentedControl): set global focus styles (#5140)
73796d3
* Revert "revert: set global focus styles (#5114)"
This reverts commit 9f37707.
* fix(SegmentedControl): add offset to globalFocusStyle
* test(SegmentedControl): add e2e focus tests
* test(vrt): update snapshots
* test(SegmentedControl): only test focus state on button and icon stories
* Revert "test(vrt): update snapshots"
This reverts commit 5736299.
* test(vrt): update snapshots
---------
Co-authored-by: francinelucca <francinelucca@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@broccolinisoupbroccolinisoupbroccolinisoup approved these changes
@francineluccafrancineluccaAwaiting requested review from francinelucca

Assignees

No one assigned

Labels

integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpmskip changesetThis change does not need a changelogstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshblack@francinelucca@broccolinisoup