Uh oh!
There was an error while loading. Please reload this page.
Allow primitives dep to be if version 9 OR 10 and add it to peerDep - #5177
Merged
Conversation
🦋 Changeset detectedLatest commit: 3b67144 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
lukasoppermanntemporarily deployed
to
github-pages
October 27, 2024 11:02 — with 
GitHub Actions
Inactive
Contributor
size-limit report 📦
|
keithamus
approved these changes
Oct 27, 2024
joshblack
requested changes
Oct 29, 2024
Uh oh!
There was an error while loading. Please reload this page.
lukasoppermannforce-pushed
the
update-primitves-dep
branch
from
November 4, 2024 09:57
23883b5 to
02d68d3Comparelukasoppermannforce-pushed
the
update-primitves-dep
branch
from
November 4, 2024 09:58
02d68d3 to
33e569eComparejoshblack
approved these changes
Nov 4, 2024
joshblack
enabled auto-merge
November 4, 2024 16:09
lukasoppermannforce-pushed
the
update-primitves-dep
branch
from
November 4, 2024 20:26
33e569e to
3b67144Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow primitives dep to be if version 9 OR 10 and add it to peerDep
Closeshttps://github.com/github/primer/issues/4322
Changelog
Changed
dependency
@primer/primitivesto allow both major version9and10and move it from dependency to peer dendencyRollout strategy
Testing & Reviewing
Merge checklist