Uh oh!
There was an error while loading. Please reload this page.
feat(Spinner): Convert Spinner to CSS module behind feature flag - #5188
Merged
Conversation
Co-authored-by: Hussam Ghazzi <hussam-i-am@github.com> Co-authored-by: Josh Black <joshblack@github.com> Co-authored-by: Jon Rohan <yes@jonrohan.codes>
🦋 Changeset detectedLatest commit: 46f9dcb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
randall-krauskopftemporarily deployed
to
github-pages
October 29, 2024 17:15 — with 
GitHub Actions
Inactive
Contributor
size-limit report 📦
|
randall-krauskopftemporarily deployed
to
github-pages
October 29, 2024 17:55 — with GitHub Actions
Inactive
randall-krauskopftemporarily deployed
to
github-pages
October 29, 2024 18:19 — with GitHub Actions
Inactive
randall-krauskopftemporarily deployed
to
github-pages
October 29, 2024 18:30 — with GitHub Actions
Inactive
🟢 golden-jobs completed with status |
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/349176 |
randall-krauskopf
marked this pull request as ready for review
October 30, 2024 14:26
randall-krauskopf
marked this pull request as draft
October 30, 2024 14:26
randall-krauskopf
marked this pull request as ready for review
October 30, 2024 14:44
jonrohan
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closeshttps://github.com/github/primer/issues/4293
Changelog
Changed
Convert spinner component to css module behind feature flag
Rollout strategy
Testing & Reviewing