feat(ProgressBar): Convert ProgressBar to CSS modules behind team feature flag by TylerJDev · Pull Request #5304 · primer/react

TylerJDev · 2024-11-15T16:48:53Z

Closeshttps://github.com/github/primer/issues/4304

Changelog

New

Converts ProgressBar to CSS modules behind team feature flag

Rollout strategy

Patch release
Minor release
Major release; if selected, include a written rollout or migration plan
None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Added/updated tests
Added/updated documentation
Added/updated previews (Storybook)
Changes are SSR compatible
Tested in Chrome
Tested in Firefox
Tested in Safari
Tested in Edge
(GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

changeset-bot · 2024-11-15T16:48:58Z

🦋 Changeset detected

Latest commit: a7161a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-11-15T16:49:25Z

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

github-actions · 2024-11-15T16:52:14Z

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	100.62 KB (+0.23% 🔺)
packages/react/dist/browser.umd.js	100.93 KB (+0.12% 🔺)

primer-integration · 2024-11-18T14:43:59Z

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/351565

primer-integration · 2024-11-18T15:00:19Z

🔴 golden-jobs completed with status failure.

jonrohan · 2024-11-18T18:27:56Z

+ border-radius: var(--borderRadius-small);
+ gap: 2px;
+
+ &[data-progress-display='inline'] {


Something we're doing for the data- attribute selectors is wrapping in :where() which brings the specificity down on the selector so it's easier to override in dotcom.
Suggested change
&[data-progress-display='inline'] {
&:where([data-progress-display='inline']) {

jonrohan

Looks great 👍🏻

TylerJDev added 2 commits November 14, 2024 15:56

Start module convert
6237866

Add more stuff
46e02c4

github-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 15, 2024

TylerJDev temporarily deployed to github-pages November 15, 2024 16:51 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-5304 November 15, 2024 16:51 Inactive

Add even more stuff
2f5caa6

TylerJDev temporarily deployed to github-pages November 15, 2024 18:06 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-5304 November 15, 2024 18:06 Inactive

Add rest of styles needed
b2fc244

TylerJDev temporarily deployed to github-pages November 18, 2024 13:31 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-5304 November 18, 2024 13:31 Inactive

Merge branch 'main' into tylerjdev/progressbar-css-modules
041e2e8

TylerJDev temporarily deployed to github-pages November 18, 2024 13:44 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-5304 November 18, 2024 13:44 Inactive

lint and format
0952721

TylerJDev temporarily deployed to github-pages November 18, 2024 14:36 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-5304 November 18, 2024 14:36 Inactive

github-actionsBot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 18, 2024

Merge branch 'main' into tylerjdev/progressbar-css-modules
244e61b

TylerJDev temporarily deployed to github-pages November 18, 2024 18:08 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-5304 November 18, 2024 18:08 Inactive

TylerJDev marked this pull request as ready for review November 18, 2024 18:24

TylerJDev requested a review from a team as a code owner November 18, 2024 18:24

TylerJDev requested a review from jonrohan November 18, 2024 18:24

jonrohan reviewed Nov 18, 2024
View reviewed changes

TylerJDev added 2 commits November 18, 2024 13:53

Add changeset
0f33ceb

Add where
0ba5d32

TylerJDev temporarily deployed to github-pages November 18, 2024 18:57 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-5304 November 18, 2024 18:58 Inactive

jonrohan approved these changes Nov 18, 2024
View reviewed changes

TylerJDev added this pull request to the merge queue Nov 18, 2024

TylerJDev removed this pull request from the merge queue due to a manual request Nov 18, 2024

Refactor E2E, add dev story
dd2a2bc

TylerJDev temporarily deployed to github-pages November 18, 2024 22:55 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-5304 November 18, 2024 22:56 Inactive

TylerJDev added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 19, 2024

Add label to progressbar
f282411

TylerJDev temporarily deployed to github-pages November 19, 2024 14:28 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-5304 November 19, 2024 14:28 Inactive

test(vrt): update snapshots
a7161a5

primerBot requested a review from a team as a code owner November 19, 2024 14:29

primerBot requested a review from emilybrick November 19, 2024 14:29

github-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 19, 2024

primerBotdeployed to github-pages November 19, 2024 14:32 View deployment

github-actionsBottemporarily deployed to storybook-preview-5304 November 19, 2024 14:32 Inactive

TylerJDev added this pull request to the merge queue Nov 19, 2024

Merged via the queue into main with commit a3fc488Nov 19, 2024

TylerJDev deleted the tylerjdev/progressbar-css-modules branch November 19, 2024 14:57

primerBot mentioned this pull request Nov 19, 2024
Release tracking (37.6.0) #5296
Merged

Navigation Menu

Uh oh!

feat(ProgressBar): Convert ProgressBar to CSS modules behind team feature flag - #5304

feat(ProgressBar): Convert ProgressBar to CSS modules behind team feature flag#5304
TylerJDev merged 12 commits into
mainfrom
tylerjdev/progressbar-css-modules

TylerJDev commented Nov 15, 2024•
edited
Loading

Uh oh!

changeset-botBot commented Nov 15, 2024•
edited
Loading

Uh oh!

github-actionsBot commented Nov 15, 2024

Uh oh!

github-actionsBot commented Nov 15, 2024•
edited
Loading

Uh oh!

primer-integrationBot commented Nov 18, 2024

Uh oh!

primer-integrationBot commented Nov 18, 2024

Uh oh!

jonrohanNov 18, 2024

Uh oh!

jonrohan left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	&[data-progress-display='inline'] {
	&:where([data-progress-display='inline']) {

Uh oh!

Conversation

TylerJDev commented Nov 15, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

New

Rollout strategy

Testing & Reviewing

Merge checklist

Uh oh!

changeset-botBot commented Nov 15, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actionsBot commented Nov 15, 2024

Uh oh!

github-actionsBot commented Nov 15, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

primer-integrationBot commented Nov 18, 2024

Uh oh!

primer-integrationBot commented Nov 18, 2024

Uh oh!

jonrohanNov 18, 2024

Choose a reason for hiding this comment

Uh oh!

jonrohan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

TylerJDev commented Nov 15, 2024•
edited
Loading

changeset-botBot commented Nov 15, 2024•
edited
Loading

github-actionsBot commented Nov 15, 2024•
edited
Loading