feat(SelectPanel2): Convert SelectPanel2 to CSS modules by hussam-i-am · Pull Request #5325 · primer/react

hussam-i-am · 2024-11-21T23:16:59Z

Resolveshttps://github.com/github/primer/issues/4295

Changelog

New

Changed

Converts SelectPanel to CSS modules without feature flag since it is only used internally and does not currently accept an sx or className prop

Removed

Rollout strategy

Patch release
Minor release
Major release; if selected, include a written rollout or migration plan
None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Added/updated tests
Added/updated documentation
Added/updated previews (Storybook)
Changes are SSR compatible
Tested in Chrome
Tested in Firefox
Tested in Safari
Tested in Edge
(GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

…flag

changeset-bot · 2024-11-21T23:17:03Z

🦋 Changeset detected

Latest commit: 09de060

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-11-21T23:17:30Z

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

github-actions · 2024-11-21T23:20:29Z

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	102.49 KB (0%)
packages/react/dist/browser.umd.js	102.85 KB (0%)

…am/select-panel-2-css-modules

…ub.com/primer/react into hussam-i-am/select-panel-2-css-modules

francinelucca

Mostly LGTM, just one question around classNames.
I'm wondering if we want to rethink shipping under a FF, I do see this being pulled in from /experimental in dotcom unless I'm reading this wrong?

github-actions · 2024-11-22T19:25:10Z

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

github-actions · 2024-11-22T19:29:16Z

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

hussam-i-am · 2024-11-22T19:30:37Z

@francinelucca Readded the sx props and update classNames to pass through from props

primer-integration · 2024-11-22T19:39:35Z

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/352234

primer-integration · 2024-11-22T19:57:00Z

🟢 golden-jobs completed with status success.

francinelucca

Looks good! one non-blocking suggestion

francinelucca · 2024-11-22T20:34:03Z

- <Box sx={{display: 'flex', alignItems: 'center', gap: 2}}>
- <Checkbox id={checkboxId} sx={{marginTop: 0}} {...props} />
- <InputLabel htmlFor={checkboxId} sx={{fontSize: 0}}>
+ <Box


nit: should we render theses Boxes as native divs when enabled?

I believe it defaults to a div and doesn't need it in those cases

hussam-i-am added 2 commits November 21, 2024 23:14

feat(SelectPanel): Convert SelectPanel to CSS modules behind feature …
7c56e33
…flag

update changeset
05a46dc

hussam-i-am self-assigned this Nov 21, 2024

github-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 21, 2024

hussam-i-am temporarily deployed to github-pages November 21, 2024 23:18 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-5325 November 21, 2024 23:19 Inactive

Merge branch 'main' into hussam-i-am/select-panel-2-css-modules
59c17e0

hussam-i-am temporarily deployed to github-pages November 21, 2024 23:33 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-5325 November 21, 2024 23:34 Inactive

hussam-i-am added 2 commits November 21, 2024 23:45

Merge branch 'main' ofhttps://github.com/primer/reactinto hussam-i-…
5ec7005
…am/select-panel-2-css-modules

Merge branch 'hussam-i-am/select-panel-2-css-modules' ofhttps://gith…
430a734
…ub.com/primer/react into hussam-i-am/select-panel-2-css-modules

hussam-i-am temporarily deployed to github-pages November 21, 2024 23:47 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-5325 November 21, 2024 23:48 Inactive

style fixes
1e2eda0

hussam-i-am temporarily deployed to github-pages November 22, 2024 00:12 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-5325 November 22, 2024 00:12 Inactive

fix icon color
0cf2336

hussam-i-am temporarily deployed to github-pages November 22, 2024 00:27 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-5325 November 22, 2024 00:27 Inactive

hussam-i-am marked this pull request as ready for review November 22, 2024 16:08

hussam-i-am requested a review from a team as a code owner November 22, 2024 16:08

hussam-i-am requested a review from francinelucca November 22, 2024 16:08

francinelucca reviewed Nov 22, 2024
View reviewed changes

Comment threadpackages/react/src/experimental/SelectPanel2/SelectPanel.tsx Outdated

francinelucca requested changes Nov 22, 2024
View reviewed changes

readd sx
94820fe

github-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 22, 2024

hussam-i-am temporarily deployed to github-pages November 22, 2024 19:27 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-5325 November 22, 2024 19:27 Inactive

update order
09de060

github-actionsBot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 22, 2024

hussam-i-am deployed to github-pages November 22, 2024 19:30 — with GitHub Actions View deployment

github-actionsBot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 22, 2024

github-actionsBottemporarily deployed to storybook-preview-5325 November 22, 2024 19:30 Inactive

francinelucca approved these changes Nov 22, 2024
View reviewed changes

hussam-i-am added this pull request to the merge queue Nov 25, 2024

Merged via the queue into main with commit cdc4da1Nov 25, 2024

hussam-i-am deleted the hussam-i-am/select-panel-2-css-modules branch November 25, 2024 16:04

primerBot mentioned this pull request Nov 25, 2024
Release tracking (37.6.0) #5296
Merged

Navigation Menu

Uh oh!

feat(SelectPanel2): Convert SelectPanel2 to CSS modules - #5325

feat(SelectPanel2): Convert SelectPanel2 to CSS modules#5325
hussam-i-am merged 9 commits into
mainfrom
hussam-i-am/select-panel-2-css-modules

hussam-i-am commented Nov 21, 2024

Uh oh!

changeset-botBot commented Nov 21, 2024•
edited
Loading

Uh oh!

github-actionsBot commented Nov 21, 2024

Uh oh!

github-actionsBot commented Nov 21, 2024•
edited
Loading

Uh oh!

Uh oh!

francinelucca left a comment

Uh oh!

github-actionsBot commented Nov 22, 2024

Uh oh!

github-actionsBot commented Nov 22, 2024

Uh oh!

hussam-i-am commented Nov 22, 2024

Uh oh!

primer-integrationBot commented Nov 22, 2024

Uh oh!

primer-integrationBot commented Nov 22, 2024

Uh oh!

francinelucca left a comment

Uh oh!

francineluccaNov 22, 2024

Uh oh!

hussam-i-amNov 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

hussam-i-am commented Nov 21, 2024

Changelog

New

Changed

Removed

Rollout strategy

Testing & Reviewing

Merge checklist

Uh oh!

changeset-botBot commented Nov 21, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actionsBot commented Nov 21, 2024

Uh oh!

github-actionsBot commented Nov 21, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Uh oh!

francinelucca left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Nov 22, 2024

Uh oh!

github-actionsBot commented Nov 22, 2024

Uh oh!

hussam-i-am commented Nov 22, 2024

Uh oh!

primer-integrationBot commented Nov 22, 2024

Uh oh!

primer-integrationBot commented Nov 22, 2024

Uh oh!

francinelucca left a comment

Choose a reason for hiding this comment

Uh oh!

francineluccaNov 22, 2024

Choose a reason for hiding this comment

Uh oh!

hussam-i-amNov 22, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-botBot commented Nov 21, 2024•
edited
Loading

github-actionsBot commented Nov 21, 2024•
edited
Loading