fix(TooltipV2): delay tooltip opening time by 50ms by francinelucca · Pull Request #5350 · primer/react

francinelucca · 2024-12-04T00:48:13Z

Closeshttps://github.com/github/primer/issues/4432

Adds a 50ms delay to show the tooltip when triggered via the mouse to prevent showing tooltips when the user is just "passing by"

Changelog

New

Set Tooltip event after mouseEnter under a timeout to prevent opening when the mouse is just "passing by"

Changed

use fireEvent in overlay test instead of userEvent to trigger click.

Rollout strategy

Patch release
Minor release
Major release; if selected, include a written rollout or migration plan
None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Added/updated tests
Added/updated documentation
Added/updated previews (Storybook)
Changes are SSR compatible
Tested in Chrome
Tested in Firefox
Tested in Safari
Tested in Edge
(GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

changeset-bot · 2024-12-04T00:48:17Z

🦋 Changeset detected

Latest commit: bed7c74

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-12-04T00:48:43Z

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

github-actions · 2024-12-04T00:51:40Z

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	103.5 KB (+0.15% 🔺)
packages/react/dist/browser.umd.js	103.81 KB (+0.07% 🔺)

…2-bug-tooltip-on-iconbutton-should-not-show-up-instantly

…se when non-matching element

francinelucca · 2024-12-05T01:19:50Z


 // open second menu
-await user.click(container.getByText('Create list'))
+fireEvent.click(container.getByText('Create list'))


I tried for minute to get this to work with user.click, I replicated this test manually in storybook and it works as expected. I noticed userEvent was triggering different events than manual testing did 🤷🏽‍♀️

francinelucca · 2024-12-05T01:20:26Z

+ } else {
+ setIsPopoverOpen(false)


Fixes bug where overlay would stay "stuck" and not able to close via keyboard due to popOver state being open but it not actually being in the DOM

…-should-not-show-up-instantly

github-actions · 2024-12-11T21:57:42Z

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

github-actions · 2024-12-11T22:00:09Z

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

primer-integration · 2024-12-12T00:46:14Z

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/354745

primer-integration · 2024-12-12T16:42:34Z

🟢 golden-jobs completed with status success.

fix(TooltipV2): delay tooltip opening time by ms
d4e1eb7

github-actionsBot added the staff Author is a staff member label Dec 4, 2024

francinelucca added status: wip component: Tooltip Issues related to the Tooltip component enhancement New feature or request and removed staff Author is a staff member labels Dec 4, 2024

github-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 4, 2024

Create five-mayflies-flash.md
3fcdbdd

francinelucca temporarily deployed to github-pages December 4, 2024 00:51 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-5350 December 4, 2024 00:51 Inactive

Merge branch 'main' of github.com:primer/react into francinelucca/443…
f62bf38
…2-bug-tooltip-on-iconbutton-should-not-show-up-instantly

francinelucca temporarily deployed to github-pages December 4, 2024 15:34 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-5350 December 4, 2024 15:35 Inactive

fix(Overlay): use fire event for click in test and set popover to fal…
4d4cbcc
…se when non-matching element

francinelucca temporarily deployed to github-pages December 5, 2024 01:15 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-5350 December 5, 2024 01:15 Inactive

fix(Overlay): remove redundant await
a5bbca5

francinelucca temporarily deployed to github-pages December 5, 2024 01:20 — with GitHub Actions Inactive

francinelucca commented Dec 5, 2024
View reviewed changes

github-actionsBottemporarily deployed to storybook-preview-5350 December 5, 2024 01:20 Inactive

francinelucca changed the title ~~fix(TooltipV2): delay tooltip opening time by ms~~fix(TooltipV2): delay tooltip opening time by 50msDec 5, 2024

Merge branch 'main' into francinelucca/4432-bug-tooltip-on-iconbutton…
bb7ebcb
…-should-not-show-up-instantly

francinelucca temporarily deployed to github-pages December 5, 2024 01:25 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-5350 December 5, 2024 01:25 Inactive

github-actionsBot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 5, 2024

Merge branch 'main' into francinelucca/4432-bug-tooltip-on-iconbutton…
2073d41
…-should-not-show-up-instantly

francinelucca temporarily deployed to github-pages December 11, 2024 21:59 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-5350 December 11, 2024 21:59 Inactive

fix(TooltipV2): change type of timeoutRef
bed7c74

github-actionsBot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 11, 2024

francinelucca deployed to github-pages December 11, 2024 22:01 — with GitHub Actions View deployment

github-actionsBottemporarily deployed to storybook-preview-5350 December 11, 2024 22:01 Inactive

github-actionsBot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Dec 12, 2024

francinelucca removed the status: review needed label Dec 13, 2024

francinelucca added this pull request to the merge queue Dec 13, 2024

Merged via the queue into main with commit 4bcf78bDec 13, 2024

francinelucca deleted the francinelucca/4432-bug-tooltip-on-iconbutton-should-not-show-up-instantly branch December 13, 2024 01:39

primerBot mentioned this pull request Dec 13, 2024
Release tracking (37.8.0) #5404
Merged

Navigation Menu

Uh oh!

fix(TooltipV2): delay tooltip opening time by 50ms - #5350

fix(TooltipV2): delay tooltip opening time by 50ms#5350
francinelucca merged 11 commits into
mainfrom
francinelucca/4432-bug-tooltip-on-iconbutton-should-not-show-up-instantly

francinelucca commented Dec 4, 2024•
edited
Loading

Uh oh!

changeset-botBot commented Dec 4, 2024•
edited
Loading

Uh oh!

github-actionsBot commented Dec 4, 2024

Uh oh!

github-actionsBot commented Dec 4, 2024•
edited
Loading

Uh oh!

francineluccaDec 5, 2024

Uh oh!

francineluccaDec 5, 2024

Uh oh!

github-actionsBot commented Dec 11, 2024

Uh oh!

github-actionsBot commented Dec 11, 2024

Uh oh!

primer-integrationBot commented Dec 12, 2024

Uh oh!

primer-integrationBot commented Dec 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

francinelucca commented Dec 4, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

New

Changed

Rollout strategy

Testing & Reviewing

Merge checklist

Uh oh!

changeset-botBot commented Dec 4, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actionsBot commented Dec 4, 2024

Uh oh!

github-actionsBot commented Dec 4, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

francineluccaDec 5, 2024

Choose a reason for hiding this comment

Uh oh!

francineluccaDec 5, 2024

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Dec 11, 2024

Uh oh!

github-actionsBot commented Dec 11, 2024

Uh oh!

primer-integrationBot commented Dec 12, 2024

Uh oh!

primer-integrationBot commented Dec 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

francinelucca commented Dec 4, 2024•
edited
Loading

changeset-botBot commented Dec 4, 2024•
edited
Loading

github-actionsBot commented Dec 4, 2024•
edited
Loading