Skip to content

Revert "chore(Skeleton): Remove the CSS module feature flag from Skeleton" - #5496

Merged
francinelucca merged 1 commit into
mainfrom
revert-5461-css_modules_remove_skeleton
Jan 6, 2025
Merged

Revert "chore(Skeleton): Remove the CSS module feature flag from Skeleton"#5496
francinelucca merged 1 commit into
mainfrom
revert-5461-css_modules_remove_skeleton

Conversation

@francinelucca

@francineluccafrancinelucca commented Jan 6, 2025

Copy link
Copy Markdown
Member

Reverts #5461

Flag is being moved to ga in #5439, we're pushing this change to a release further down

@francinelucca
francinelucca requested a review from a team as a code ownerJanuary 6, 2025 17:08
@changeset-bot

changeset-botBot commented Jan 6, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1d178be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actionsgithub-actionsBot added the staff Author is a staff member label Jan 6, 2025
@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 6, 2025
@github-actions

github-actionsBot commented Jan 6, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5496 January 6, 2025 17:11 Inactive
@github-actions

github-actionsBot commented Jan 6, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js104.26 KB (+0.55% 🔺)
packages/react/dist/browser.umd.js104.71 KB (+0.54% 🔺)

@francinelucca
francinelucca added this pull request to the merge queueJan 6, 2025
Merged via the queue into main with commit 23d77f8Jan 6, 2025
@francinelucca
francinelucca deleted the revert-5461-css_modules_remove_skeleton branch January 6, 2025 17:24
@francinelucca

francinelucca commented Jan 6, 2025

Copy link
Copy Markdown
MemberAuthor

Before un-reverting this, look into dotcom issue where skeleton is not showing up on with these changes in. Example: https://github.com/primer/react/branches/all loading state

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonrohanjonrohanjonrohan approved these changes

Assignees

No one assigned

Labels

integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpmstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@francinelucca@jonrohan