Skip to content

chore(Header): Remove CSS modules feature flag from Header - #5510

Merged
jonrohan merged 6 commits into
mainfrom
css_modules_remove_header
Feb 14, 2025
Merged

chore(Header): Remove CSS modules feature flag from Header#5510
jonrohan merged 6 commits into
mainfrom
css_modules_remove_header

Conversation

@jonrohan

@jonrohanjonrohan commented Jan 8, 2025

Copy link
Copy Markdown
Member

Changelog

New

Changed

Removed

Remove CSS modules feature flag from Header

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot

changeset-botBot commented Jan 8, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d65af11

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactMinor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actionsgithub-actionsBot added the staff Author is a staff member label Jan 8, 2025
@github-actions

github-actionsBot commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 8, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5510 January 8, 2025 23:43 Inactive
@github-actions

github-actionsBot commented Jan 8, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js105.53 KB (-0.16% 🔽)
packages/react/dist/browser.umd.js105.88 KB (-0.13% 🔽)

@primer-integration

primer-integrationBot commented Feb 13, 2025

Copy link
Copy Markdown

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/362515

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5510 February 13, 2025 18:05 Inactive
@primer-integration

primer-integrationBot commented Feb 13, 2025

Copy link
Copy Markdown

🟢 golden-jobs completed with status success.

@github-actionsgithub-actionsBot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Feb 13, 2025
@jonrohan
jonrohan marked this pull request as ready for review February 13, 2025 20:03
@jonrohan
jonrohan requested a review from a team as a code ownerFebruary 13, 2025 20:03
@jonrohan
jonrohan requested review from francinelucca and mperrotti and removed request for mperrottiFebruary 13, 2025 20:03
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5510 February 13, 2025 20:32 Inactive
@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 13, 2025
@github-actions

github-actionsBot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actionsgithub-actionsBot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 13, 2025
@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 13, 2025
@github-actions

github-actionsBot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions
github-actionsBot requested a deployment to storybook-preview-5510 February 13, 2025 20:58 Abandoned
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5510 February 13, 2025 21:15 Inactive
francinelucca
francinelucca approved these changes Feb 14, 2025
View reviewed changes

@francineluccafrancinelucca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@jonrohan
jonrohan added this pull request to the merge queueFeb 14, 2025
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Feb 14, 2025
@jonrohan
jonrohan added this pull request to the merge queueFeb 14, 2025
Merged via the queue into main with commit 37a91b5Feb 14, 2025
@jonrohan
jonrohan deleted the css_modules_remove_header branch February 14, 2025 17:40
@primerprimerBot mentioned this pull request Feb 14, 2025
Merged
hectahertz pushed a commit that referenced this pull request Mar 20, 2025
@jonrohan@hectahertz
chore(Header): Remove CSS modules feature flag from Header (#5510)
4741d98
* Remove CSS modules feature flag from Header
* Adjust Header for as prop
* Create shaggy-comics-whisper.md
* Remove FeatureFlagElement from Header tests
* Remove unused FeatureFlags import in Header test
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@francineluccafrancineluccafrancinelucca approved these changes

Assignees

No one assigned

Labels

integration-tests: passingChanges in this PR do NOT cause breaking changes in gh/ghintegration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpmstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonrohan@francinelucca