Skip to content

docs: ensure announcement is made on dynamic content - #5565

Closed
khiga8 wants to merge 2 commits into
mainfrom
kh-fix-10031
Closed

docs: ensure announcement is made on dynamic content#5565
khiga8 wants to merge 2 commits into
mainfrom
kh-fix-10031

Conversation

@khiga8

@khiga8khiga8 commented Jan 17, 2025

Copy link
Copy Markdown
Contributor

Fixes: https://github.com/github/accessibility-audits/issues/10031

Changed

Adds the announceOnShow attribute to the AlertStatus to ensure that polite announcements happen when the component is shown

Side note: I noticed these announcement components don't have a corresponding Primer docs page or guidance on how to use. Is that intentional? happy to follow up here separately.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Merge checklist

  • Added/updated previews (Storybook)

@changeset-bot

changeset-botBot commented Jan 17, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1359cd7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@khiga8
khiga8 marked this pull request as ready for review January 17, 2025 16:54
@khiga8
khiga8 requested a review from a team as a code ownerJanuary 17, 2025 16:54
@khiga8khiga8 added the skip changeset This change does not need a changelog label Jan 17, 2025
@khiga8khiga8 changed the title Ensure announcement is made for dynamic contentdocs: ensure announcement is made on dynamic contentJan 17, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5565 January 17, 2025 16:57 Inactive
@github-actions

github-actionsBot commented Jan 17, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js104.22 KB (0%)
packages/react/dist/browser.umd.js104.58 KB (0%)

@khiga8
khiga8 marked this pull request as draft January 17, 2025 17:00
@khiga8

Copy link
Copy Markdown
ContributorAuthor

superceded by #5568

@khiga8khiga8 closed this Jan 17, 2025
@jonrohan
jonrohan deleted the kh-fix-10031 branch May 9, 2025 18:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changesetThis change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@khiga8