Uh oh!
There was an error while loading. Please reload this page.
Banner allows critical variant to use ondismiss - #5583
Merged
joshblack merged 6 commits intoJan 23, 2025
Conversation
🦋 Changeset detectedLatest commit: 2206468 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brphelpsforce-pushed
the
banner-allows-critical-ondismiss
branch
from
January 21, 2025 21:39
3f57069 to
18a7d8bCompare
joshblack
left a comment
Member
There was a problem hiding this comment.
Thanks so much for putting this together! Just left a couple of comments 👍
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Josh Black <joshblack@github.com>
joshblack
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#5582
Changelog
New
Changed
Banner now supports onDismiss used when using variant
critical.Removed
Rollout strategy
Testing & Reviewing
I added a unit test and updated the example to use onDismiss.
Merge checklist