Skip to content

refactor(ButtonBase): update selector to have specificty 0,1,0 - #5584

Merged
joshblack merged 3 commits into
mainfrom
4703-update-buttonbase
Jan 22, 2025
Merged

refactor(ButtonBase): update selector to have specificty 0,1,0#5584
joshblack merged 3 commits into
mainfrom
4703-update-buttonbase

Conversation

@joshblack

@joshblackjoshblack commented Jan 21, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Closeshttps://github.com/github/primer/issues/4703

Changelog

New

Changed

  • Update .ButtonBase to have specificity of at least 0,1,0 to no longer get overridden by reset styles or equivalent selectors with 0,1,0 specificity

Removed

Rollout strategy

  • Patch release

@changeset-bot

changeset-botBot commented Jan 21, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c78eae4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actionsgithub-actionsBot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jan 21, 2025
@github-actions

github-actionsBot commented Jan 21, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5584 January 21, 2025 21:43 Inactive
@github-actions

github-actionsBot commented Jan 21, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js104.47 KB (0%)
packages/react/dist/browser.umd.js104.76 KB (0%)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5584 January 21, 2025 21:50 Inactive
langermank
langermank reviewed Jan 21, 2025
View reviewed changes
Comment threadpackages/react/src/Button/ButtonBase.module.css
@joshblack
joshblack marked this pull request as ready for review January 22, 2025 17:22
@joshblack
joshblack requested a review from a team as a code ownerJanuary 22, 2025 17:22
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5584 January 22, 2025 17:24 Inactive
@primer-integration

primer-integrationBot commented Jan 22, 2025

Copy link
Copy Markdown

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/358837

@primer-integration

primer-integrationBot commented Jan 22, 2025

Copy link
Copy Markdown

🔴 golden-jobs completed with status failure.

@github-actionsgithub-actionsBot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jan 22, 2025
mperrotti
mperrotti approved these changes Jan 22, 2025
View reviewed changes

@mperrottimperrotti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used the preview release to test in primer-docs, and this works as expected 🎉

langermank
langermank approved these changes Jan 22, 2025
View reviewed changes

@langermanklangermank left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@joshblack
joshblack added this pull request to the merge queueJan 22, 2025
Merged via the queue into main with commit b661959Jan 22, 2025
@joshblack
joshblack deleted the 4703-update-buttonbase branch January 22, 2025 18:56
@primerprimerBot mentioned this pull request Jan 22, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@mperrottimperrottimperrotti approved these changes
@langermanklangermanklangermank approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

integration-tests: failingChanges in this PR cause breaking changes in gh/ghstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshblack@mperrotti@langermank