Skip to content

Remove feature-flag and extra @aat - #5638

Merged
kendallgassner merged 2 commits into
mainfrom
kendallg/axe-follow-up
Jan 31, 2025
Merged

Remove feature-flag and extra @aat#5638
kendallgassner merged 2 commits into
mainfrom
kendallg/axe-follow-up

Conversation

@kendallgassner

@kendallgassnerkendallgassner commented Jan 31, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

I missed two comments on my previous PR (#5592):

This PR aims to fix them

Closes #

N/A

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@kendallgassnerkendallgassner added the skip changeset This change does not need a changelog label Jan 31, 2025
@changeset-bot

changeset-botBot commented Jan 31, 2025•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f855458

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actionsBot commented Jan 31, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js105.38 KB (0%)
packages/react/dist/browser.umd.js105.83 KB (0%)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5638 January 31, 2025 19:53 Inactive
@kendallgassnerkendallgassner changed the title [Draft] Remove feature-flag and extra @aatRemove feature-flag and extra @aatJan 31, 2025
@kendallgassner
kendallgassner marked this pull request as ready for review January 31, 2025 20:14
@kendallgassner
kendallgassner requested a review from a team as a code ownerJanuary 31, 2025 20:14
@github-actions
github-actionsBot requested a deployment to storybook-preview-5638 January 31, 2025 20:18 Abandoned
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5638 January 31, 2025 20:23 Inactive
khiga8
khiga8 approved these changes Jan 31, 2025
View reviewed changes

@khiga8khiga8 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up here 💟

@kendallgassner
kendallgassner added this pull request to the merge queueJan 31, 2025
Merged via the queue into main with commit c9b0a72Jan 31, 2025
@kendallgassner
kendallgassner deleted the kendallg/axe-follow-up branch January 31, 2025 22:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblackjoshblackjoshblack approved these changes
@khiga8khiga8khiga8 approved these changes
@camertroncamertronAwaiting requested review from camertroncamertron is a code owner automatically assigned from primer/engineer-reviewers

Assignees

No one assigned

Labels

skip changesetThis change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kendallgassner@joshblack@khiga8