Uh oh!
There was an error while loading. Please reload this page.
Fix LinkButton types - #5655
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 58a2334 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
hectahertztemporarily deployed
to
github-pages
February 4, 2025 18:11 — with 
GitHub Actions
Inactive
hectahertztemporarily deployed
to
github-pages
February 4, 2025 18:49 — with GitHub Actions
Inactive
hectahertz
enabled auto-merge
February 6, 2025 13:04
hectahertz
disabled auto-merge
February 6, 2025 13:04
hectahertztemporarily deployed
to
github-pages
February 6, 2025 13:18 — with GitHub Actions
Inactive
hectahertztemporarily deployed
to
github-pages
February 7, 2025 12:40 — with GitHub Actions
Inactive
hectahertztemporarily deployed
to
github-pages
February 7, 2025 13:00 — with GitHub Actions
Inactive
hectahertzforce-pushed
the
hectahertz/fix-linkbutton-types
branch
from
February 7, 2025 18:38
3fd995f to
43998beCompareContributor
size-limit report 📦
|
hectahertztemporarily deployed
to
github-pages
February 7, 2025 19:03 — with GitHub Actions
Inactive
hectahertztemporarily deployed
to
github-pages
February 10, 2025 15:06 — with GitHub Actions
Inactive
hectahertz added a commit
that referenced
this pull request
Mar 20, 2025
* Fix LinkButton and ButtonBase Typescript types * Use LinkButton in LinkButton stories * Add changeset * Remove export
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closeshttps://github.com/github/primer/issues/4743
Changelog
The old
ButtonBasePropsincluded the the ref. This was overriding thePolymorphicForwardRefComponent<'a', MyProps>onLinkButtonTLDR; Properly type
LinkButton. The props were not properly inherited the type checking didn't actually work properly.Changed
Fixes issues with the LinkButton props.
Changes the
LinkButtonstories to actually use the LinkButton component.Rollout strategy
Testing & Reviewing
Merge checklist