Skip to content

DialogV2: Add alpha status to docs - #5706

Merged
TylerJDev merged 6 commits into
mainfrom
promote-dialog-to-alpha
Mar 10, 2025
Merged

DialogV2: Add alpha status to docs#5706
TylerJDev merged 6 commits into
mainfrom
promote-dialog-to-alpha

Conversation

@TylerJDev

@TylerJDevTylerJDev commented Feb 18, 2025

Copy link
Copy Markdown
Member

Closeshttps://github.com/github/primer/issues/4749

We should promote DialogV2 to alpha status in the Primer docs. We have already accomplished most of the work in v37, this ensures that the component has the correct status in our docs.

Changelog

Changed

  • Changed status draft to alpha
  • Move DialogV1 to deprecated stories in Storybook

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot

changeset-botBot commented Feb 18, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 12a08a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actionsBot commented Feb 18, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js106.01 KB (0%)
packages/react/dist/browser.umd.js106.29 KB (0%)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5706 February 18, 2025 17:14 Inactive
@TylerJDevTylerJDev added the skip changeset This change does not need a changelog label Feb 18, 2025
@TylerJDev
TylerJDev marked this pull request as ready for review February 18, 2025 17:42
@TylerJDev
TylerJDev requested a review from a team as a code ownerFebruary 18, 2025 17:42
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5706 February 22, 2025 14:03 Inactive
@TylerJDevTylerJDev added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Feb 22, 2025
@primer
primerBot requested a review from a team as a code ownerFebruary 22, 2025 14:28
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Feb 22, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5706 February 22, 2025 14:41 Inactive
@TylerJDev

Copy link
Copy Markdown
MemberAuthor

With #5740 being merged, we can go ahead and merge this too! The status will be reflected after our next release, which will also include a fix that closes out the remaining Dialog accessibility issues.

@TylerJDev
TylerJDev added this pull request to the merge queueMar 10, 2025
Merged via the queue into main with commit 9324036Mar 10, 2025
@TylerJDev
TylerJDev deleted the promote-dialog-to-alpha branch March 10, 2025 14:43
hectahertz pushed a commit that referenced this pull request Mar 20, 2025
Co-authored-by: TylerJDev <TylerJDev@users.noreply.github.com>
Co-authored-by: Jon Rohan <yes@jonrohan.codes>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changesetThis change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TylerJDev@joshblack@jonrohan