Skip to content

chore: Ensure class names conform to PascalCase#5716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hussam-i-am merged 14 commits into from
Mar 4, 2025
Merged

chore: Ensure class names conform to PascalCase #5716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2910934
chore: Ensure class names conform to PascalCase
hussam-i-am Feb 20, 2025
bdf5c06
revert lock file
hussam-i-am Feb 20, 2025
f1891ea
format fix
hussam-i-am Feb 20, 2025
f629583
fix lint disables
hussam-i-am Feb 20, 2025
55eac0e
Merge branch 'main' of https://github.com/primer/react into hussam-i-…
hussam-i-am Feb 21, 2025
99e8df2
conform to BEM
hussam-i-am Feb 21, 2025
6ae6fbe
Merge branch 'main' into hussam-i-am/stylelint-pascal
jonrohan Feb 22, 2025
ae16ef3
Merge branch 'main' into hussam-i-am/stylelint-pascal
hussam-i-am Mar 3, 2025
e1ae9b5
Add typed-css-modules
hussam-i-am Mar 4, 2025
6f3e6ff
Merge branch 'hussam-i-am/stylelint-pascal' of https://github.com/pri…
hussam-i-am Mar 4, 2025
be9f73f
add prebuild step to generate files
hussam-i-am Mar 4, 2025
4d04814
limit to src files
hussam-i-am Mar 4, 2025
039d234
update to postbuild
hussam-i-am Mar 4, 2025
fc925ea
remove post built
hussam-i-am Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/seven-falcons-fry.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@primer/react": minor
---

chore: Ensure class names conform to PascalCase
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,3 +40,6 @@ blob-report

# ESLint
.eslintcache

# CSS modules type definitions
*.module.css.d.ts
4 changes: 2 additions & 2 deletions examples/theming/src/app/components/PageHeader/PageHeader.module.css
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
.header {
.Header {
display: flex;
justify-content: space-between;
align-items: center;
min-height: 4rem;
padding: var(--base-size-16);
}

.logo {
.Logo {
color: inherit;
text-decoration: none;
}
4 changes: 2 additions & 2 deletions examples/theming/src/app/components/PageHeader/PageHeader.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,8 @@ import classes from './PageHeader.module.css'

export function PageHeader() {
return (
<header className={classes.header}>
<Link href="/" className={classes.logo}>
<header className={classes.Header}>
<Link href="/" className={classes.Logo}>
Primer
</Link>
<ThemePreference />
Expand Down
6 changes: 3 additions & 3 deletions examples/theming/src/app/components/ThemePreference/ThemePreference.module.css
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
/* stylelint-disable selector-no-qualifying-type */
html[data-color-mode='dark'] .light {
html[data-color-mode='dark'] .Light {
display: none !important;
}

html[data-color-mode='light'] .dark,
html[data-color-mode='auto'] .dark {
html[data-color-mode='light'] .Dark,
html[data-color-mode='auto'] .Dark {
display: none !important;
}
5 changes: 2 additions & 3 deletions examples/theming/src/app/components/ThemePreference/ThemePreference.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@

import {SunIcon, MoonIcon} from '@primer/octicons-react'
import {Button, useTheme} from '@primer/react'
import {clsx} from 'clsx'
import classes from './ThemePreference.module.css'

export function ThemePreference() {
Expand DownExpand Up@@ -30,8 +29,8 @@ export function ThemePreference() {
})
}}
>
<SunIcon className={clsx(classes.icon, classes.light)} />
<MoonIcon className={clsx(classes.icon, classes.dark)} />
<SunIcon className={classes.Light} />
<MoonIcon className={classes.Dark} />
</Button>
)
}
263 changes: 263 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 6 additions & 4 deletions package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,7 @@
"build:docs:preview": "NODE_OPTIONS=--openssl-legacy-provider script/build-docs preview",
"build:components.json": "npm run build:components.json -w @primer/react",
"build:hooks.json": "npm run build:hooks.json -w @primer/react",
"lint": "eslint '**/*.{js,ts,tsx,md,mdx}' --max-warnings=0",
"lint": "eslint '**/*.{js,ts,tsx,md,mdx}' --max-warnings=0 --ignore-pattern '**/*.module.css.d.ts'",
"lint:css": "stylelint --rd -q '**/*.css'",
"lint:css:fix": "npm run lint:css -- --fix",
"lint:fix": "npm run lint -- --fix",
Expand All@@ -29,8 +29,9 @@
"test:update": "npm run test -- --updateSnapshot",
"test:watch": "npm run test -- --watch",
"test:coverage": "npm run test -- --coverage",
"test:type-check": "tsc --noEmit",
"type-check": "tsc --noEmit && npm run type-check -ws --if-present",
"test:type-check": "npm run type-css-modules && tsc --noEmit",
"type-check": "npm run type-css-modules && tsc --noEmit && npm run type-check -ws --if-present",
"type-css-modules": "tcm -p **/packages/react/src/**/*.module.css",
"release": "npm run build && changeset publish",
"reset": "script/reset",
"size": "size-limit"
Expand All@@ -46,8 +47,8 @@
"@changesets/changelog-github": "0.5.0",
"@changesets/cli": "2.27.1",
"@github/axe-github": "0.6.1",
"@github/mini-throttle": "2.1.1",
"@github/markdownlint-github": "^0.6.0",
"@github/mini-throttle": "2.1.1",
"@github/prettier-config": "0.0.6",
"@mdx-js/react": "1.6.22",
"@playwright/test": "^1.50.0",
Expand DownExpand Up@@ -80,6 +81,7 @@
"rimraf": "5.0.5",
"size-limit": "11.1.5",
"stylelint": "16.9.0",
"typed-css-modules": "0.9.1",
"typescript": "^5.7.2"
},
"optionalDependencies": {
Expand Down
Loading