Skip to content

feat(FormControl): Promote FormControl to CSS modules GA feature flag - #5738

Merged
joshblack merged 3 commits into
mainfrom
jshark/form-control-ga
Mar 10, 2025
Merged

feat(FormControl): Promote FormControl to CSS modules GA feature flag#5738
joshblack merged 3 commits into
mainfrom
jshark/form-control-ga

Conversation

@jamieshark

@jamiesharkjamieshark commented Mar 5, 2025

Copy link
Copy Markdown
Contributor

Towards https://github.com/github/primer/issues/3812

Changelog

New

Changed

FormControl feature flag is promoted to GA

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@jamieshark
jamieshark requested a review from a team as a code ownerMarch 5, 2025 20:22
@jamieshark
jamieshark requested a review from jonrohanMarch 5, 2025 20:22
@changeset-bot

changeset-botBot commented Mar 5, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c48141c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jamiesharkjamieshark self-assigned this Mar 5, 2025
@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 5, 2025
@github-actions

github-actionsBot commented Mar 5, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions

github-actionsBot commented Mar 5, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js105.99 KB (-0.03% 🔽)
packages/react/dist/browser.umd.js106.38 KB (-0.05% 🔽)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5738 March 5, 2025 20:36 Inactive
@jamieshark

jamieshark commented Mar 7, 2025

Copy link
Copy Markdown
ContributorAuthor

waiting for #5717 to merge (cc: @jonrohan)

jonrohan
jonrohan reviewed Mar 7, 2025
View reviewed changes

@jonrohanjonrohan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point this is the only component left not in ga. Seems like we could just go ahead and include in the latest #5717

But gonna leave that up to @francinelucca as RC

Comment thread.changeset/rare-experts-beg.md Outdated
@francinelucca

francinelucca commented Mar 7, 2025

Copy link
Copy Markdown
Member

Go for it 🔥

@jamieshark@jonrohan
Update .changeset/rare-experts-beg.md
c48141c
Co-authored-by: Jon Rohan <yes@jonrohan.codes>
@joshblack
joshblack added this pull request to the merge queueMar 10, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5738 March 10, 2025 16:30 Inactive
Merged via the queue into main with commit a4137bcMar 10, 2025
@joshblack
joshblack deleted the jshark/form-control-ga branch March 10, 2025 16:45
@primerprimerBot mentioned this pull request Mar 10, 2025
Merged
hectahertz pushed a commit that referenced this pull request Mar 20, 2025
@jamieshark@jonrohan@hectahertz
feat(FormControl): Promote FormControl to CSS modules GA feature flag (…
1764412
…#5738)
Co-authored-by: Jon Rohan <yes@jonrohan.codes>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonrohanjonrohanjonrohan left review comments
@hussam-i-amhussam-i-amhussam-i-am approved these changes
@francineluccafrancineluccafrancinelucca approved these changes

Assignees

@jamiesharkjamieshark

Labels

integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jamieshark@francinelucca@jonrohan@hussam-i-am@joshblack