Skip to content

Add Notice to SelectPanel - #5790

Merged
hectahertz merged 7 commits into
mainfrom
hectahertz/select-panel-add-notice
Mar 21, 2025
Merged

Add Notice to SelectPanel#5790
hectahertz merged 7 commits into
mainfrom
hectahertz/select-panel-add-notice

Conversation

@hectahertz

@hectahertzhectahertz commented Mar 18, 2025

Copy link
Copy Markdown
Contributor

Closeshttps://github.com/github/primer/issues/4114

Changelog

New

Adds the notice prop to SelectPanel that renders an info/warning/error message to the user.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Screenshot of the info noticeScreenshot of the warning noticeScreenshot of the error notice

Merge checklist

@hectahertz
hectahertz requested a review from a team as a code ownerMarch 18, 2025 18:45
@changeset-bot

changeset-botBot commented Mar 18, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 50319d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactMinor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hectahertz
hectahertz requested review from Copilot and removed request for siddharthkpMarch 18, 2025 18:46
@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 18, 2025
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new notice prop to the SelectPanel component to render an informational, warning, or error message along with respective icons.

  • Adds a notice prop to SelectPanel with associated styling and icon mappings
  • Updates the component stories and changeset documentation to demonstrate and track the new feature

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

FileDescription
packages/react/src/SelectPanel/SelectPanel.features.stories.tsxAdds a new story "WithNotice" demonstrating the notice prop functionality
.changeset/slick-teams-check.mdUpdates the changeset to reflect a minor release for the notice feature
packages/react/src/SelectPanel/SelectPanel.tsxImplements the notice prop functionality within the SelectPanel component
Files not reviewed (1)
  • packages/react/src/SelectPanel/SelectPanel.module.css: Language not supported

Tip: Turn on automatic Copilot reviews for this repository to get quick feedback on every pull request. Learn more

@github-actions

github-actionsBot commented Mar 18, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js105.38 KB (+0.34% 🔺)
packages/react/dist/browser.umd.js105.74 KB (+0.37% 🔺)

@github-actions
github-actionsBot requested a deployment to storybook-preview-5790 March 18, 2025 18:55 Abandoned
Comment threadpackages/react/src/SelectPanel/SelectPanel.tsx Outdated
@francinelucca

Copy link
Copy Markdown
Member

@emilybrick can we get design review on this? 🙏

@francineluccafrancinelucca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking so good! some minor details.
Also let's make sure we run integration tests 🙏

@emilybrickemilybrick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually LGTM. ✨

@francineluccafrancinelucca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5790 March 21, 2025 12:08 Inactive
@hectahertz
hectahertz added this pull request to the merge queueMar 21, 2025
Merged via the queue into main with commit acc5d27Mar 21, 2025
@hectahertz
hectahertz deleted the hectahertz/select-panel-add-notice branch March 21, 2025 12:48
@primerprimerBot mentioned this pull request Mar 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@hectahertz@francinelucca@emilybrick