Test Dialog VRT

.changeset/chilled-walls-cheer.md

@@ -0,0 +1,5 @@
+---
+"@primer/react": patch
+---
+
+Show `Tooltip` on close button in `Dialog`

packages/react/src/Dialog/Dialog.module.css

@@ -119,14 +119,14 @@
  }
 
  @media screen and (prefers-reduced-motion: no-preference) {
- animation: Overlay--motion-scaleFade 0.2s cubic-bezier(0.33, 1, 0.68, 1) 0s 1 normal none running;
+ animation: Overlay--motion-scaleFade 0.2s cubic-bezier(0.33, 1, 0.68, 1) 1ms 1 normal none running;
  }
 
  &[data-position-regular='center'] {
  border-radius: var(--borderRadius-large, var(--borderRadius-large));
 
  @media screen and (prefers-reduced-motion: no-preference) {
- animation: Overlay--motion-scaleFade 0.2s cubic-bezier(0.33, 1, 0.68, 1) 0s 1 normal none running;
+ animation: Overlay--motion-scaleFade 0.2s cubic-bezier(0.33, 1, 0.68, 1) 1ms 1 normal none running;
  }
  }
 
@@ -138,7 +138,7 @@
  border-bottom-left-radius: 0;
 
  @media screen and (prefers-reduced-motion: no-preference) {
- animation: Overlay--motion-slideInRight 0.25s cubic-bezier(0.33, 1, 0.68, 1) 0s 1 normal none running;
+ animation: Overlay--motion-slideInRight 0.25s cubic-bezier(0.33, 1, 0.68, 1) 1ms 1 normal none running;
  }
  }
 
@@ -150,7 +150,7 @@
  border-bottom-right-radius: 0;
 
  @media screen and (prefers-reduced-motion: no-preference) {
- animation: Overlay--motion-slideInLeft 0.25s cubic-bezier(0.33, 1, 0.68, 1) 0s 1 normal none running;
+ animation: Overlay--motion-slideInLeft 0.25s cubic-bezier(0.33, 1, 0.68, 1) 1ms 1 normal none running;
  }
  }
 
@@ -193,7 +193,7 @@
  border-bottom-left-radius: 0;
 
  @media screen and (prefers-reduced-motion: no-preference) {
- animation: Overlay--motion-slideUp 0.25s cubic-bezier(0.33, 1, 0.68, 1) 0s 1 normal none running;
+ animation: Overlay--motion-slideUp 0.25s cubic-bezier(0.33, 1, 0.68, 1) 1ms 1 normal none running;
  }
  }
 
@@ -206,7 +206,7 @@
  flex-grow: 1;
 
  @media screen and (prefers-reduced-motion: no-preference) {
- animation: Overlay--motion-scaleFade 0.2s cubic-bezier(0.33, 1, 0.68, 1) 0s 1 normal none running;
+ animation: Overlay--motion-scaleFade 0.2s cubic-bezier(0.33, 1, 0.68, 1) 1ms 1 normal none running;
  }
  }
  }

packages/react/src/Dialog/Dialog.tsx

@@ -677,10 +677,7 @@ const Buttons: React.FC<React.PropsWithChildren<{buttons: DialogButtonProps[]}>>
 }
 
 const CloseButton: React.FC<React.PropsWithChildren<{onClose: () => void}>> = ({onClose}) => {
- return (
- // eslint-disable-next-line primer-react/a11y-remove-disable-tooltip
- <IconButton unsafeDisableTooltip={true} icon={XIcon} aria-label="Close" onClick={onClose} variant="invisible" />
- )
+ return <IconButton icon={XIcon} aria-label="Close" onClick={onClose} variant="invisible" />
 }
 
 /**