Skip to content

Revert "SelectPanel: Implement empty state " - #5824

Closed
TylerJDev wants to merge 1 commit into
mainfrom
revert-5142-select-panel-empty-state
Closed

Revert "SelectPanel: Implement empty state "#5824
TylerJDev wants to merge 1 commit into
mainfrom
revert-5142-select-panel-empty-state

Conversation

@TylerJDev

@TylerJDevTylerJDev commented Mar 26, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Reverts #5142, will be added back to implement changes without roving tabindex pattern.

@changeset-bot

changeset-botBot commented Mar 26, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 40ba77d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actionsgithub-actionsBot added the staff Author is a staff member label Mar 26, 2025
@github-actions

github-actionsBot commented Mar 26, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 26, 2025
@github-actions

github-actionsBot commented Mar 26, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js105.76 KB (-0.02% 🔽)
packages/react/dist/browser.umd.js106.24 KB (+0.02% 🔺)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5824 March 26, 2025 14:46 Inactive
@TylerJDev
TylerJDev marked this pull request as ready for review March 26, 2025 14:46
@TylerJDev
TylerJDev requested review from a team as code ownersMarch 26, 2025 14:46
@primer
primerBot deleted the revert-5142-select-panel-empty-state branch June 30, 2026 18:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@francineluccafrancineluccaAwaiting requested review from francinelucca
@maximedegrevemaximedegreveAwaiting requested review from maximedegrevemaximedegreve was automatically assigned from primer/design-reviewers

Assignees

No one assigned

Labels

integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpmstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TylerJDev@francinelucca