Skip to content

Revert "Add workaround for Chrome bug where KeybindingHint in combination with aria-labelledby results in incorrect label" - #5839

Merged
francinelucca merged 3 commits into
mainfrom
revert-5818-keybindinghint-labelledby-bug
Mar 31, 2025
Merged

Revert "Add workaround for Chrome bug where KeybindingHint in combination with aria-labelledby results in incorrect label"#5839
francinelucca merged 3 commits into
mainfrom
revert-5818-keybindinghint-labelledby-bug

Conversation

@francinelucca

@francineluccafrancinelucca commented Mar 29, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Reverts #5818

Main integration CI is currently red, looks like this PR contributed to some of the errors, seeing less errors in this revert than in main

@changeset-bot

changeset-botBot commented Mar 29, 2025•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e56ba43

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actionsgithub-actionsBot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Mar 29, 2025
@github-actions

github-actionsBot commented Mar 29, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions

github-actionsBot commented Mar 29, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js105.36 KB (-0.01% 🔽)
packages/react/dist/browser.umd.js105.8 KB (+0.07% 🔺)

@primer-integration

primer-integrationBot commented Mar 29, 2025

Copy link
Copy Markdown

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/370189

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5839 March 29, 2025 04:31 Inactive
@primer-integration

primer-integrationBot commented Mar 29, 2025

Copy link
Copy Markdown

🔴 golden-jobs completed with status failure.

@github-actionsgithub-actionsBot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Mar 29, 2025
@francineluccafrancinelucca added the skip changeset This change does not need a changelog label Mar 29, 2025
@francinelucca
francinelucca marked this pull request as ready for review March 29, 2025 04:49
@francinelucca
francinelucca requested a review from a team as a code ownerMarch 29, 2025 04:49
@francineluccafrancinelucca added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Mar 29, 2025
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 29, 2025
@francineluccafrancinelucca changed the title TEST: Revert "Add workaround for Chrome bug where KeybindingHint in combination with aria-labelledby results in incorrect label"Revert "Add workaround for Chrome bug where KeybindingHint in combination with aria-labelledby results in incorrect label"Mar 31, 2025
@francineluccafrancinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 31, 2025
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 31, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5839 March 31, 2025 15:24 Inactive
@francinelucca
francinelucca added this pull request to the merge queueMar 31, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5839 March 31, 2025 15:40 Inactive
@francinelucca
francinelucca removed this pull request from the merge queue due to a manual request Mar 31, 2025
@francinelucca
francinelucca added this pull request to the merge queueMar 31, 2025
Merged via the queue into main with commit eb134ceMar 31, 2025
@francinelucca
francinelucca deleted the revert-5818-keybindinghint-labelledby-bug branch March 31, 2025 16:03
@iansan5653iansan5653 mentioned this pull request Mar 31, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblackjoshblackjoshblack approved these changes
@TylerJDevTylerJDevAwaiting requested review from TylerJDevTylerJDev is a code owner automatically assigned from primer/engineer-reviewers

Assignees

No one assigned

Labels

integration-tests: failingChanges in this PR cause breaking changes in gh/ghskip changesetThis change does not need a changelogstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@francinelucca@joshblack