Skip to content

chore(SideNav): Remove the CSS modules feature flag from the SideNav component - #5876

Merged
jonrohan merged 2 commits into
mainfrom
remove_css_modules_flag_sidenav
Apr 4, 2025
Merged

chore(SideNav): Remove the CSS modules feature flag from the SideNav component#5876
jonrohan merged 2 commits into
mainfrom
remove_css_modules_flag_sidenav

Conversation

@jonrohan

@jonrohanjonrohan commented Apr 3, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Closes #

Changelog

New

Changed

Removed

Remove the CSS modules feature flag from the SideNav component

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot

changeset-botBot commented Apr 3, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c21b36a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactMinor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actionsgithub-actionsBot added the staff Author is a staff member label Apr 3, 2025
@github-actions

github-actionsBot commented Apr 3, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 3, 2025
@github-actions

github-actionsBot commented Apr 3, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js104 KB (-0.28% 🔽)
packages/react/dist/browser.umd.js104.42 KB (-0.29% 🔽)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5876 April 3, 2025 22:43 Inactive
@primer-integration

primer-integrationBot commented Apr 3, 2025

Copy link
Copy Markdown

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/371352

@primer-integration

primer-integrationBot commented Apr 3, 2025

Copy link
Copy Markdown

🟢 golden-jobs completed with status success.

@github-actionsgithub-actionsBot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 3, 2025
@jonrohan
jonrohan marked this pull request as ready for review April 3, 2025 23:34
@jonrohan
jonrohan requested a review from a team as a code ownerApril 3, 2025 23:34
@jonrohan
jonrohan requested a review from TylerJDevApril 3, 2025 23:34
@jonrohan
jonrohan enabled auto-merge April 3, 2025 23:34
@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 4, 2025
@github-actions

github-actionsBot commented Apr 4, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5876 April 4, 2025 02:50 Inactive
@jonrohan
jonrohan added this pull request to the merge queueApr 4, 2025
Merged via the queue into main with commit a78c820Apr 4, 2025
@jonrohan
jonrohan deleted the remove_css_modules_flag_sidenav branch April 4, 2025 16:16
@primerprimerBot mentioned this pull request Apr 4, 2025
Merged
jonrohan added a commit that referenced this pull request Apr 10, 2025
@jonrohan
chore(SideNav): Remove the CSS modules feature flag from the SideNav …
62cfae1
…component (#5876)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblackjoshblackjoshblack approved these changes
@TylerJDevTylerJDevAwaiting requested review from TylerJDevTylerJDev is a code owner automatically assigned from primer/engineer-reviewers

Assignees

No one assigned

Labels

integration-tests: passingChanges in this PR do NOT cause breaking changes in gh/ghintegration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpmstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonrohan@joshblack