Skip to content

fix(SelectPanel): differentiate onCancel gesture from escape - #5908

Merged
francinelucca merged 2 commits into
mainfrom
fix/differentiate-on-cancel-gesture
Apr 9, 2025
Merged

fix(SelectPanel): differentiate onCancel gesture from escape#5908
francinelucca merged 2 commits into
mainfrom
fix/differentiate-on-cancel-gesture

Conversation

@francinelucca

@francineluccafrancinelucca commented Apr 8, 2025

Copy link
Copy Markdown
Member

'escape' is used to save the selection by design, adding a different gesture for onCancel so that consumers can catch the difference.

Changelog

New

  • 'cancel' gesture for onOpenChange in SelectPanel

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@francinelucca
francinelucca requested a review from a team as a code ownerApril 8, 2025 23:00
@changeset-bot

changeset-botBot commented Apr 8, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 58ac6a8

The changes in this PR will be included in the next version bump.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actionsgithub-actionsBot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 8, 2025
@github-actions

github-actionsBot commented Apr 8, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions

github-actionsBot commented Apr 8, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js104.44 KB (+0.09% 🔺)
packages/react/dist/browser.umd.js104.76 KB (+0.03% 🔺)

@github-actions
github-actionsBot requested a deployment to storybook-preview-5908 April 8, 2025 23:09 Abandoned
@primer-integration

primer-integrationBot commented Apr 8, 2025

Copy link
Copy Markdown

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/372054

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5908 April 8, 2025 23:23 Inactive
@github-actionsgithub-actionsBot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 8, 2025
@primer-integration

primer-integrationBot commented Apr 9, 2025

Copy link
Copy Markdown

🟢 golden-jobs completed with status success.

@github-actionsgithub-actionsBot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Apr 9, 2025
@francinelucca
francinelucca added this pull request to the merge queueApr 9, 2025
Merged via the queue into main with commit 8e7bc0eApr 9, 2025
@francinelucca
francinelucca deleted the fix/differentiate-on-cancel-gesture branch April 9, 2025 13:26
@primerprimerBot mentioned this pull request Apr 9, 2025
Merged
jonrohan pushed a commit that referenced this pull request Apr 10, 2025
@francinelucca@jonrohan
fix(SelectPanel): differentiate onCancel gesture from escape (#5908)
9eec099
hectahertz pushed a commit that referenced this pull request May 20, 2025
@francinelucca@hectahertz
fix(SelectPanel): differentiate onCancel gesture from escape (#5908)
c01aa98
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TylerJDevTylerJDevTylerJDev approved these changes
@jonrohanjonrohanAwaiting requested review from jonrohanjonrohan is a code owner automatically assigned from primer/engineer-reviewers

Assignees

No one assigned

Labels

integration-tests: passingChanges in this PR do NOT cause breaking changes in gh/ghstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@francinelucca@TylerJDev