Skip to content

Add gap between ActionList label and trailingVisual - #6177

Merged
langermank merged 31 commits into
mainfrom
add-col-gap-actionlist
Jun 30, 2025
Merged

Add gap between ActionList label and trailingVisual#6177
langermank merged 31 commits into
mainfrom
add-col-gap-actionlist

Conversation

@langermank

@langermanklangermank commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

Adds proper gap between label and trailing visual. Also removes the inactive text if its not needed.

Closes#6154

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot

changeset-botBot commented Jun 6, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 746fb33

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jun 6, 2025
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions

github-actionsBot commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js92.48 KB (-0.04% 🔽)
packages/react/dist/browser.umd.js92.7 KB (+0.16% 🔺)

@github-actions
github-actionsBot requested a deployment to storybook-preview-6177 June 6, 2025 23:40 Abandoned
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6177 June 6, 2025 23:54 Inactive
Base automatically changed from css_modules_remove_flag/actionlist to mainJune 11, 2025 19:00
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6177 June 28, 2025 01:19 Inactive
@langermank
langermank marked this pull request as ready for review June 30, 2025 16:23
CopilotAI review requested due to automatic review settings June 30, 2025 16:23
@langermank
langermank requested a review from a team as a code ownerJune 30, 2025 16:23
@joshblack

Copy link
Copy Markdown
Member

Would it be easy to add a screenshot/e2e test to capture this behavior or not really? 👀

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@langermank

Copy link
Copy Markdown
ContributorAuthor

@joshblack great call, I'm doing a few other bugs for AL this week and I'll add this into a followup PR!

@langermank
langermank added this pull request to the merge queueJun 30, 2025
Merged via the queue into main with commit 5e1ed83Jun 30, 2025
@langermank
langermank deleted the add-col-gap-actionlist branch June 30, 2025 18:44
@primerprimerBot mentioned this pull request Jun 30, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ActionList.TrailingVisual has insufficient left padding

6 participants

@langermank@joshblack@jonrohan@francinelucca@hussam-i-am