Uh oh!
There was an error while loading. Please reload this page.
fix Banner spacing - #6190
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 5f281fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
size-limit report 📦
|
llastflowers
marked this pull request as ready for review
June 10, 2025 19:07
Contributor
There was a problem hiding this comment.
Pull Request Overview
This patch fixes the vertical alignment of the Banner component and corrects a typo in the story description.
- Aligns banner content centrally instead of at the start
- Fixes typo in the Playground description text
- Adds a changeset to trigger a patch release
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Banner.stories.tsx | Corrected typo in the description arg (en able → enable) |
| Banner.module.css | Changed align-items from start to center in container |
| .changeset/big-hairs-agree.md | Added changeset entry for a patch release |
llastflowers
marked this pull request as draft
June 10, 2025 21:08
…tions are present, so that the button and x will be aligned when seen together, but there will will be no x position change if there is an x with no BannerActions
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as outdated.
This comment was marked as outdated.
llastflowers
commented
Jun 11, 2025
ContributorAuthor
Documenting some context for the newer code changes based on slack DMs with The change that addressed this original issue (before/after):
was causing this view to look wonky because the
So I have conditionally applied a matching style to the dismiss
but the
Margins adjusted with buttons vs. default:
|
This comment was marked as outdated.
This comment was marked as outdated.
jonrohan
approved these changes
Jun 11, 2025
lukasoppermann
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closeshttps://github.com/github/primer/issues/3720
Changelog
Changed
Styling update addressing banner spacing issues--see vertical alignment on single line banner below (before / after):
Rollout strategy
Testing & Reviewing
I used the following Playground settings to see this view where the issue was occurring (viewable here):
Merge checklist