Skip to content

Fix PageHeader context bar font-weight - #6256

Merged
langermank merged 3 commits into
mainfrom
fix-pageheader-weight
Jun 30, 2025
Merged

Fix PageHeader context bar font-weight#6256
langermank merged 3 commits into
mainfrom
fix-pageheader-weight

Conversation

@langermank

@langermanklangermank commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

Closeshttps://github.com/github/primer/issues/5382

I took a look at the prev. implementation before CSS Modules and best I can tell we didn't set the weight to light. I'm not sure if this was maybe an oversight?

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot

changeset-botBot commented Jun 30, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 89f6bf2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jun 30, 2025
@github-actions
github-actionsBot requested a deployment to storybook-preview-6256 June 30, 2025 21:36 Abandoned
@github-actions

github-actionsBot commented Jun 30, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js92.48 KB (0%)
packages/react/dist/browser.umd.js92.7 KB (0%)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-6256 June 30, 2025 21:48 Inactive
@langermank
langermank marked this pull request as ready for review June 30, 2025 21:57
CopilotAI review requested due to automatic review settings June 30, 2025 21:57
@langermank
langermank requested a review from a team as a code ownerJune 30, 2025 21:57
CopilotAI reviewed Jun 30, 2025

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@langermank
langermank added this pull request to the merge queueJun 30, 2025
Merged via the queue into main with commit 0318b4bJun 30, 2025
@langermank
langermank deleted the fix-pageheader-weight branch June 30, 2025 22:21
@primerprimerBot mentioned this pull request Jun 30, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@joshblackjoshblackjoshblack approved these changes
@TylerJDevTylerJDevAwaiting requested review from TylerJDevTylerJDev is a code owner automatically assigned from primer/engineer-reviewers

Assignees

No one assigned

Labels

integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@langermank@joshblack