Skip to content

Stack: Add shrink prop to Stack.Item - #6260

Merged
adierkens merged 3 commits into
mainfrom
adierkens/stack-item-shrink
Jul 14, 2025
Merged

Stack: Add shrink prop to Stack.Item#6260
adierkens merged 3 commits into
mainfrom
adierkens/stack-item-shrink

Conversation

@adierkens

@adierkensadierkens commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

Closeshttps://github.com/github/primer/issues/5139

Changelog

New

Adds the ability to supply a shrink prop to Stack.Item to control sizing behaviors when the content width exceeds the available space. It maintains the current default behavior (flex-shrink: 1)

Before/After Screenshot of adding the shrink property to a stack-item

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Merge checklist

CopilotAI review requested due to automatic review settings July 1, 2025 14:57
@adierkens
adierkens requested a review from a team as a code ownerJuly 1, 2025 14:57
@adierkens
adierkens requested a review from TylerJDevJuly 1, 2025 14:57
@changeset-bot

changeset-botBot commented Jul 1, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: bb82603

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactMinor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 1, 2025
@github-actions

github-actionsBot commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js92.38 KB (-0.11% 🔽)
packages/react/dist/browser.umd.js92.52 KB (-0.2% 🔽)

@github-actions
github-actionsBot requested a deployment to storybook-preview-6260 July 1, 2025 15:06 Abandoned
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6260 July 1, 2025 15:20 Inactive
CopilotAI reviewed Jul 1, 2025

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@joshblack
joshblack requested a review from langermankJuly 1, 2025 19:18

@joshblackjoshblack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! 🙌 Also tagged in @langermank to review, just wanted her to have a chance to review before merging

@langermanklangermank left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets goooo! 🚀

},
}

function createArgMetaData(category: string): InputType {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh this is so clean 😍

@adierkens
adierkens added this pull request to the merge queueJul 14, 2025
Merged via the queue into main with commit 8210573Jul 14, 2025
@adierkens
adierkens deleted the adierkens/stack-item-shrink branch July 14, 2025 15:19
@primerprimerBot mentioned this pull request Jul 12, 2025
llastflowers pushed a commit that referenced this pull request Jul 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@adierkens@joshblack@langermank@TylerJDev