Skip to content

Fix Button styles while dragging inactive variants - #6277

Merged
liuliu-dev merged 4 commits into
mainfrom
liuliu/fix-button-inactive-drag-styles
Jul 10, 2025
Merged

Fix Button styles while dragging inactive variants#6277
liuliu-dev merged 4 commits into
mainfrom
liuliu/fix-button-inactive-drag-styles

Conversation

@liuliu-dev

@liuliu-devliuliu-dev commented Jul 2, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Closes#5375

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

CopilotAI review requested due to automatic review settings July 2, 2025 23:34
@liuliu-dev
liuliu-dev requested a review from a team as a code ownerJuly 2, 2025 23:34
@liuliu-dev
liuliu-dev requested a review from TylerJDevJuly 2, 2025 23:34
@changeset-bot

changeset-botBot commented Jul 2, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7fd68eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

CopilotAI reviewed Jul 2, 2025
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • packages/react/src/Button/ButtonBase.module.css: Language not supported

@github-actions

github-actionsBot commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 2, 2025
@github-actions

github-actionsBot commented Jul 2, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js92.01 KB (0%)
packages/react/dist/browser.umd.js92.29 KB (0%)

@github-actions
github-actionsBot requested a deployment to storybook-preview-6277 July 2, 2025 23:45 Abandoned
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6277 July 2, 2025 23:59 Inactive
@liuliu-devliuliu-dev added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 3, 2025
@primer
primerBot requested a review from a team as a code ownerJuly 3, 2025 00:14
@primer
primerBot requested a review from mperrottiJuly 3, 2025 00:14
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 3, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6277 July 3, 2025 00:28 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6277 July 3, 2025 21:29 Inactive
@liuliu-dev
liuliu-devforce-pushed the liuliu/fix-button-inactive-drag-styles branch 2 times, most recently from 4b527c2 to 5a7a1b6CompareJuly 7, 2025 18:22
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6277 July 7, 2025 18:25 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6277 July 7, 2025 18:35 Inactive
@github-actionsgithub-actionsBot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 7, 2025
TylerJDev
TylerJDev approved these changes Jul 8, 2025
View reviewed changes

@TylerJDevTylerJDev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@liuliu-dev
liuliu-dev enabled auto-merge July 8, 2025 16:09
@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 10, 2025
@github-actions

github-actionsBot commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@liuliu-dev
liuliu-dev added this pull request to the merge queueJul 10, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6277 July 10, 2025 00:55 Inactive
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jul 10, 2025
@github-actionsgithub-actionsBot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 10, 2025
@github-actions

github-actionsBot commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions
github-actionsBottemporarily deployed to storybook-preview-6277 July 10, 2025 16:11 Inactive
@github-actionsgithub-actionsBot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 10, 2025
@primer-integration

primer-integrationBot commented Jul 10, 2025

Copy link
Copy Markdown

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/390046

@github-actionsgithub-actionsBot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh labels Jul 10, 2025
@primer-integration

primer-integrationBot commented Jul 10, 2025

Copy link
Copy Markdown

🟢 golden-jobs completed with status success.

@github-actionsgithub-actionsBot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Jul 10, 2025
@liuliu-dev
liuliu-dev added this pull request to the merge queueJul 10, 2025
Merged via the queue into main with commit b384225Jul 10, 2025
@liuliu-dev
liuliu-dev deleted the liuliu/fix-button-inactive-drag-styles branch July 10, 2025 18:56
@primerprimerBot mentioned this pull request Jul 10, 2025
Merged
llastflowers pushed a commit that referenced this pull request Jul 23, 2025
@liuliu-dev@primer@llastflowers
Fix Button styles while dragging inactive variants (#6277)
aa77013
Co-authored-by: primer[bot] <119360173+primer[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@TylerJDevTylerJDevTylerJDev approved these changes
@mperrottimperrottiAwaiting requested review from mperrottimperrotti was automatically assigned from primer/design-reviewers

Assignees

No one assigned

Labels

integration-tests: passingChanges in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liuliu-dev@TylerJDev