Skip to content

chore(FormControl): remove sx props - #6295

Merged
francinelucca merged 3 commits into
mainfrom
fix/remove-sx-props
Jul 7, 2025
Merged

chore(FormControl): remove sx props#6295
francinelucca merged 3 commits into
mainfrom
fix/remove-sx-props

Conversation

@francinelucca

@francineluccafrancinelucca commented Jul 7, 2025•
edited
Loading

Copy link
Copy Markdown
Member

These styles are already in css modules in the applied class https://github.com/primer/react/blob/main/packages/react/src/FormControl/FormControl.module.css#L10-L12

Changelog

Removed

  • SX props from FormControl

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

CopilotAI review requested due to automatic review settings July 7, 2025 20:10
@francinelucca
francinelucca requested a review from a team as a code ownerJuly 7, 2025 20:10
@changeset-bot

changeset-botBot commented Jul 7, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1642708

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

CopilotAI reviewed Jul 7, 2025
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes inline style props from the FormControl component in favor of CSS class-based styling. The change aims to consolidate styling approaches by removing the display, flexDirection, and alignItems props from the Box component and relying on the classes.ControlVerticalLayout CSS class instead.

  • Removes three inline style props (display, flexDirection, alignItems) from the FormControl Box component
  • Maintains styling through the existing classes.ControlVerticalLayout CSS class

@github-actionsgithub-actionsBot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 7, 2025
@github-actions

github-actionsBot commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions

github-actionsBot commented Jul 7, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js92.37 KB (-0.06% 🔽)
packages/react/dist/browser.umd.js92.49 KB (-0.09% 🔽)

@github-actions
github-actionsBot requested a deployment to storybook-preview-6295 July 7, 2025 20:15 Abandoned
@primer-integration

primer-integrationBot commented Jul 7, 2025

Copy link
Copy Markdown

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/389123

@github-actions
github-actionsBottemporarily deployed to storybook-preview-6295 July 7, 2025 20:26 Inactive
@primer-integration

primer-integrationBot commented Jul 7, 2025

Copy link
Copy Markdown

🟢 golden-jobs completed with status success.

@github-actionsgithub-actionsBot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 7, 2025
@francinelucca
francinelucca added this pull request to the merge queueJul 7, 2025
Merged via the queue into main with commit 12468d8Jul 7, 2025
@francinelucca
francinelucca deleted the fix/remove-sx-props branch July 7, 2025 20:49
@primerprimerBot mentioned this pull request Jul 7, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@joshblackjoshblackjoshblack approved these changes
@TylerJDevTylerJDevAwaiting requested review from TylerJDevTylerJDev is a code owner automatically assigned from primer/engineer-reviewers

Assignees

No one assigned

Labels

integration-tests: passingChanges in this PR do NOT cause breaking changes in gh/ghstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@francinelucca@joshblack