Skip to content

update icon padding in TextInput - #6302

Merged
llastflowers merged 18 commits into
mainfrom
llastflowers/5326/TextInput-icon-padding-fix
Jul 10, 2025
Merged

update icon padding in TextInput#6302
llastflowers merged 18 commits into
mainfrom
llastflowers/5326/TextInput-icon-padding-fix

Conversation

@llastflowers

@llastflowersllastflowers commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

Closeshttps://github.com/github/primer/issues/5326

Changelog

New

Changed

Updated padding in leading & trailing visual TextInput to 8px from 12px, unless size of input is large, in which case padding stays as 12px.

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot

changeset-botBot commented Jul 7, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 19377fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 7, 2025
@github-actions

github-actionsBot commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js92.01 KB (0%)
packages/react/dist/browser.umd.js92.29 KB (0%)

@github-actions
github-actionsBot requested a deployment to storybook-preview-6302 July 7, 2025 23:06 Abandoned
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6302 July 7, 2025 23:16 Inactive
@llastflowersllastflowers added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 7, 2025
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 7, 2025
@llastflowersllastflowers changed the title change padding before leading visual and after trailing visual from 1…update icon padding in TextInputJul 7, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6302 July 7, 2025 23:35 Inactive
@llastflowersllastflowers added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 8, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6302 July 8, 2025 20:36 Inactive
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 8, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6302 July 8, 2025 20:54 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6302 July 8, 2025 21:20 Inactive
@llastflowersllastflowers added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 8, 2025
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 9, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6302 July 9, 2025 20:18 Inactive
@llastflowers
llastflowers added this pull request to the merge queueJul 10, 2025
github-merge-queueBot pushed a commit that referenced this pull request Jul 10, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jul 10, 2025
@primer-integration

Copy link
Copy Markdown

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/390055

@github-actionsgithub-actionsBot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 10, 2025
@primer-integration

Copy link
Copy Markdown

🟢 golden-jobs completed with status success.

@github-actionsgithub-actionsBot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Jul 10, 2025
@llastflowers
llastflowers added this pull request to the merge queueJul 10, 2025
Merged via the queue into main with commit 4c9aa4bJul 10, 2025
@llastflowers
llastflowers deleted the llastflowers/5326/TextInput-icon-padding-fix branch July 10, 2025 18:48
@primerprimerBot mentioned this pull request Jul 10, 2025
llastflowers added a commit that referenced this pull request Jul 23, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passingChanges in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@llastflowers@langermank