Skip to content

chore: Migrate from toggleSxComponent to BoxWithFallback helper#6311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonrohan merged 4 commits into from
Jul 14, 2025
Merged

chore: Migrate from toggleSxComponent to BoxWithFallback helper #6311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
31e56a4
Migrate from toggleSxComponent to BoxWithFallback
jonrohan Jul 9, 2025
eab8f67
Merge branch 'main' into migrate_togglesxcomponent_boxwithfallback
jonrohan Jul 10, 2025
4db7f06
Create afraid-papayas-allow.md
jonrohan Jul 10, 2025
b3b0771
Merge branch 'main' into migrate_togglesxcomponent_boxwithfallback
jonrohan Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/afraid-papayas-allow.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

chore: Migrate from toggleSxComponent to BoxWithFallback helper
11 changes: 5 additions & 6 deletions packages/react/src/Breadcrumbs/Breadcrumbs.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@ import type {SxProp} from '../sx'
import type {ComponentProps} from '../utils/types'
import classes from './Breadcrumbs.module.css'
import type {ForwardRefComponent as PolymorphicForwardRefComponent} from '../utils/polymorphic'
import {toggleSxComponent} from '../internal/utils/toggleSxComponent'
import {BoxWithFallback} from '../internal/components/BoxWithFallback'

const SELECTED_CLASS = 'selected'

Expand All@@ -19,13 +19,12 @@ const BreadcrumbsList = ({children}: React.PropsWithChildren) => {
return <ol className={classes.BreadcrumbsList}>{children}</ol>
}

const BreadcrumbsBaseComponent = toggleSxComponent('nav') as React.ComponentType<BreadcrumbsProps>
function Breadcrumbs({className, children, sx: sxProp}: BreadcrumbsProps) {
const wrappedChildren = React.Children.map(children, child => <li className={classes.ItemWrapper}>{child}</li>)
return (
<BreadcrumbsBaseComponent className={clsx(className, classes.BreadcrumbsBase)} aria-label="Breadcrumbs" sx={sxProp}>
<BoxWithFallback as="nav" className={clsx(className, classes.BreadcrumbsBase)} aria-label="Breadcrumbs" sx={sxProp}>
<BreadcrumbsList>{wrappedChildren}</BreadcrumbsList>
</BreadcrumbsBaseComponent>
</BoxWithFallback>
)
}

Expand All@@ -37,10 +36,10 @@ type StyledBreadcrumbsItemProps = {
React.HTMLAttributes<HTMLAnchorElement> &
React.ComponentPropsWithRef<'a'>

const BreadcrumbsItemBaseComponent = toggleSxComponent('a') as React.ComponentType<StyledBreadcrumbsItemProps>
const BreadcrumbsItem = React.forwardRef(({selected, className, ...rest}, ref) => {
return (
<BreadcrumbsItemBaseComponent
<BoxWithFallback
as="a"
className={clsx(className, classes.Item, {
[SELECTED_CLASS]: selected,
[classes.ItemSelected]: selected,
Expand Down
Loading