Skip to content

fix(SelectPanel): prioritize message over loading status - #6321

Merged
francinelucca merged 14 commits into
mainfrom
5402-bug-selectpanel-is-not-rendering-the-empty-list-message-when-there-are-no-action-items
Jul 22, 2025
Merged

fix(SelectPanel): prioritize message over loading status#6321
francinelucca merged 14 commits into
mainfrom
5402-bug-selectpanel-is-not-rendering-the-empty-list-message-when-there-are-no-action-items

Conversation

@francinelucca

@francineluccafrancinelucca commented Jul 14, 2025

Copy link
Copy Markdown
Member

Closeshttps://github.com/github/primer/issues/5402

Fixes bug where the selectpanel is empty from the beginning and the loading status is displayed instead of the empty message.

Changelog

Changed

  • renders message if exists instead of loading status

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

CopilotAI review requested due to automatic review settings July 14, 2025 14:53
@francinelucca
francinelucca requested a review from a team as a code ownerJuly 14, 2025 14:53
@changeset-bot

changeset-botBot commented Jul 14, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c935294

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

CopilotAI reviewed Jul 14, 2025
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in SelectPanel where the loading status was being displayed instead of the empty message when the panel starts empty. The change prioritizes showing messages over loading indicators by reordering the conditional logic.

  • Reorders conditional checks in getBodyContent() to prioritize message display over loading status
  • Ensures that when both a message and loading state exist, the message takes precedence

@github-actionsgithub-actionsBot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 14, 2025
@github-actions

github-actionsBot commented Jul 14, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
github-actionsBot requested a deployment to storybook-preview-6321 July 14, 2025 14:57 Abandoned
@github-actions

github-actionsBot commented Jul 14, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js91.96 KB (+0.07% 🔺)
packages/react/dist/browser.umd.js92.21 KB (-0.03% 🔽)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-6321 July 14, 2025 15:06 Inactive
@francinelucca
Merge branch 'main' into 5402-bug-selectpanel-is-not-rendering-the-em…
0a451b1
…pty-list-message-when-there-are-no-action-items
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6321 July 15, 2025 14:13 Inactive
@francineluccafrancinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 15, 2025
@primer
primerBot requested a review from a team as a code ownerJuly 15, 2025 14:24
@primer
primerBot requested a review from mperrottiJuly 15, 2025 14:24
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 15, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6321 July 15, 2025 14:34 Inactive
@francinelucca
Merge branch 'main' into 5402-bug-selectpanel-is-not-rendering-the-em…
e7a6ef1
…pty-list-message-when-there-are-no-action-items
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6321 July 16, 2025 02:37 Inactive
@francineluccafrancinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 16, 2025
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 16, 2025
@francinelucca
Merge branch 'main' of github.com:primer/react into 5402-bug-selectpa…
fba2c1b
…nel-is-not-rendering-the-empty-list-message-when-there-are-no-action-items
@francinelucca
Merge branch '5402-bug-selectpanel-is-not-rendering-the-empty-list-me…
baee2f8
…ssage-when-there-are-no-action-items' of github.com:primer/react into 5402-bug-selectpanel-is-not-rendering-the-empty-list-message-when-there-are-no-action-items
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6321 July 17, 2025 03:05 Inactive
@francineluccafrancinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 17, 2025
@primer-integration

primer-integrationBot commented Jul 17, 2025

Copy link
Copy Markdown

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/391255

@github-actions
github-actionsBottemporarily deployed to storybook-preview-6321 July 17, 2025 03:23 Inactive
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 17, 2025
@github-actions
github-actionsBot requested a deployment to storybook-preview-6321 July 17, 2025 03:30 Abandoned
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6321 July 17, 2025 03:39 Inactive
@primer-integration

primer-integrationBot commented Jul 17, 2025

Copy link
Copy Markdown

🟢 golden-jobs completed with status success.

@github-actionsgithub-actionsBot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 17, 2025
@francinelucca
francinelucca added this pull request to the merge queueJul 22, 2025
Merged via the queue into main with commit 8cced18Jul 22, 2025
@francinelucca
francinelucca deleted the 5402-bug-selectpanel-is-not-rendering-the-empty-list-message-when-there-are-no-action-items branch July 22, 2025 17:05
@primerprimerBot mentioned this pull request Jul 22, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@TylerJDevTylerJDevTylerJDev approved these changes
@jonrohanjonrohanAwaiting requested review from jonrohanjonrohan is a code owner automatically assigned from primer/engineer-reviewers
@mperrottimperrottiAwaiting requested review from mperrottimperrotti was automatically assigned from primer/design-reviewers

Assignees

No one assigned

Labels

integration-tests: passingChanges in this PR do NOT cause breaking changes in gh/ghstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@francinelucca@TylerJDev