Skip to content

chore(FilteredActionList): remove modern action list FF - #6339

Merged
francinelucca merged 39 commits into
mainfrom
chore/remove-modern-actionlist-ff
Jul 30, 2025
Merged

chore(FilteredActionList): remove modern action list FF#6339
francinelucca merged 39 commits into
mainfrom
chore/remove-modern-actionlist-ff

Conversation

@francinelucca

@francineluccafrancinelucca commented Jul 18, 2025

Copy link
Copy Markdown
Member

Closeshttps://github.com/github/primer/issues/5448

Changelog

Removed

  • All modern_action_list logic from the codebase
  • deprecated FilteredActionList in favor of modern FilteredActionList

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot

changeset-botBot commented Jul 18, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ba34508

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actionsgithub-actionsBot added the staff Author is a staff member label Jul 18, 2025
@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 18, 2025
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
github-actionsBot requested a deployment to storybook-preview-6339 July 18, 2025 15:22 Abandoned
@github-actions
github-actionsBot requested a deployment to storybook-preview-6339 July 18, 2025 15:27 Abandoned
@github-actions

github-actionsBot commented Jul 18, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js89.39 KB (-3.12% 🔽)
packages/react/dist/browser.umd.js89.64 KB (-3.04% 🔽)

@github-actionsgithub-actionsBot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 18, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6339 July 18, 2025 15:58 Inactive
@francineluccafrancinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 18, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6339 July 18, 2025 16:19 Inactive
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 18, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6339 July 18, 2025 16:34 Inactive
@francineluccafrancinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 18, 2025
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 18, 2025
@github-actionsgithub-actionsBot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Jul 28, 2025
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actionsgithub-actionsBot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 28, 2025
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions
github-actionsBot requested a deployment to storybook-preview-6339 July 28, 2025 19:16 Abandoned
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6339 July 28, 2025 19:25 Inactive
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@primer-integration

Copy link
Copy Markdown

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/393002

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the primer_react_select_panel_with_modern_action_list feature flag that controlled which ActionList implementation to use in SelectPanel and FilteredActionList components. The modern ActionList implementation is now the default (and only) implementation.

  • Removed the feature flag and associated conditional logic throughout the codebase
  • Cleaned up deprecated ActionList imports and type dependencies
  • Updated exports to expose necessary types from FilteredActionList directly
  • Simplified test files by removing feature flag toggling and duplicate test scenarios

Reviewed Changes

Copilot reviewed 17 out of 192 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
packages/react/src/index.tsAdded new type exports for SelectPanel-related types
packages/react/src/tests/snapshots/exports.test.ts.snapUpdated snapshot to reflect new exported types
packages/react/src/SelectPanel/types.tsRemoved file that re-exported deprecated ActionList types
packages/react/src/SelectPanel/index.tsUpdated to export types from FilteredActionList instead of deprecated types
packages/react/src/SelectPanel/SelectPanel.tsxRemoved feature flag usage and cleaned up conditional logic
packages/react/src/SelectPanel/SelectPanel.test.tsxRemoved feature flag testing and simplified test structure
packages/react/src/SelectPanel/SelectPanel.features.stories.tsxRemoved FeatureFlags wrapper
packages/react/src/FilteredActionList/useAnnouncements.tsxUpdated import path for types
packages/react/src/FilteredActionList/types.tsAdded comprehensive type definitions for FilteredActionList
packages/react/src/FilteredActionList/index.tsUpdated exports to include all necessary types
packages/react/src/FilteredActionList/FilteredActionListWithDeprecatedActionList.tsxRemoved deprecated implementation
packages/react/src/FilteredActionList/FilteredActionListEntry.tsxRemoved feature flag entry point
packages/react/src/FilteredActionList/FilteredActionList.tsxUpdated to be the primary implementation
packages/react/src/FeatureFlags/DefaultFeatureFlags.tsRemoved the feature flag definition
packages/react/src/CircleBadge/snapshots/CircleBadge.test.tsx.snapUpdated styled-components class names
e2e/components/SelectPanel.test.tsRemoved feature flag scenarios from e2e tests
.changeset/dirty-bulldogs-smoke.mdAdded changeset for patch release
Comments suppressed due to low confidence (1)

packages/react/src/SelectPanel/SelectPanel.tsx:363

  • There is an extra closing brace that creates a syntax error. This brace should be removed as it doesn't have a corresponding opening brace.
 }

@primer-integration

Copy link
Copy Markdown

🟢 golden-jobs completed with status success.

@hectahertzhectahertz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally ✨

@primerprimerBot mentioned this pull request Jul 30, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passingChanges in this PR do NOT cause breaking changes in gh/ghstaffAuthor is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@francinelucca@hectahertz