Skip to content

fix(SelectPanel): add loading state to stories - #6374

Merged
joshblack merged 7 commits into
mainfrom
fix/selectpanel-stories-fix
Jul 23, 2025
Merged

fix(SelectPanel): add loading state to stories#6374
joshblack merged 7 commits into
mainfrom
fix/selectpanel-stories-fix

Conversation

@francinelucca

@francineluccafrancinelucca commented Jul 23, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Changelog

Changed

  • use explicit loading status in stories that have an empty message

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

CopilotAI review requested due to automatic review settings July 23, 2025 20:28
@francinelucca
francinelucca requested a review from a team as a code ownerJuly 23, 2025 20:28
@changeset-bot

changeset-botBot commented Jul 23, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 074421e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actionsgithub-actionsBot added the staff Author is a staff member label Jul 23, 2025
CopilotAI reviewed Jul 23, 2025
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds loading state functionality to SelectPanel stories to demonstrate async data fetching behavior in Storybook. The changes ensure that the SelectPanel component properly shows loading states during simulated API calls.

  • Adds loading state management to async fetch stories
  • Implements initial loading behavior with useEffect hooks
  • Updates component props to pass loading state to SelectPanel

Comment threadpackages/react/src/SelectPanel/SelectPanel.features.stories.tsx
Comment threadpackages/react/src/SelectPanel/SelectPanel.features.stories.tsx
Comment threadpackages/react/src/SelectPanel/SelectPanel.features.stories.tsx
Comment threadpackages/react/src/SelectPanel/SelectPanel.features.stories.tsx
@github-actions

github-actionsBot commented Jul 23, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js92.21 KB (0%)
packages/react/dist/browser.umd.js92.39 KB (0%)

@github-actions
github-actionsBot requested a deployment to storybook-preview-6374 July 23, 2025 20:34 Abandoned
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6374 July 23, 2025 20:43 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6374 July 23, 2025 20:54 Inactive
@francineluccafrancinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 23, 2025
llastflowers

This comment was marked as resolved.

Sign in to view

@llastflowers
llastflowers self-requested a review July 23, 2025 20:59
llastflowers
llastflowers approved these changes Jul 23, 2025
View reviewed changes

@llastflowersllastflowers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good--stories with loading work as expected ✅

@primer
primerBot requested a review from a team as a code ownerJuly 23, 2025 21:07
@primer
primerBot requested a review from mperrottiJuly 23, 2025 21:07
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 23, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6374 July 23, 2025 21:17 Inactive
@github-actions
github-actionsBot requested a deployment to storybook-preview-6374 July 23, 2025 21:26 Abandoned
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6374 July 23, 2025 21:34 Inactive
@joshblack
joshblack merged commit ad76aa8 into mainJul 23, 2025
@joshblack
joshblack deleted the fix/selectpanel-stories-fix branch July 23, 2025 21:36
@primerprimerBot mentioned this pull request Jul 23, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@llastflowersllastflowersllastflowers approved these changes
@hectahertzhectahertzAwaiting requested review from hectahertzhectahertz is a code owner automatically assigned from primer/engineer-reviewers
@mperrottimperrottiAwaiting requested review from mperrottimperrotti was automatically assigned from primer/design-reviewers

Assignees

No one assigned

Labels

staffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@francinelucca@llastflowers@joshblack