Skip to content

chore: use Banner instead of custom implementation for SelectPanel notice - #6669

Merged
francinelucca merged 28 commits into
mainfrom
5647-bug-info-icon-misalignment-in-selectpanel-with-notice
Sep 11, 2025
Merged

chore: use Banner instead of custom implementation for SelectPanel notice#6669
francinelucca merged 28 commits into
mainfrom
5647-bug-info-icon-misalignment-in-selectpanel-with-notice

Conversation

@francinelucca

@francineluccafrancinelucca commented Aug 26, 2025

Copy link
Copy Markdown
Member

Closeshttps://github.com/github/primer/issues/5647

Changelog

Changed

  • Replaced custom SelectPanel notice implementation in favor of Banner

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

CopilotAI review requested due to automatic review settings August 26, 2025 02:21
@francinelucca
francinelucca requested a review from a team as a code ownerAugust 26, 2025 02:21
@changeset-bot

changeset-botBot commented Aug 26, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8971a92

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
NameType
@primer/reactPatch
@primer/styled-reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actionsgithub-actionsBot added the staff Author is a staff member label Aug 26, 2025

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the SelectPanel component's notice display to use the reusable Banner component instead of a custom implementation. This change improves code consistency and maintainability by leveraging an existing design system component.

Key Changes

  • Replaced custom notice implementation with Banner component from the design system
  • Updated variant mapping to handle Banner's 'critical' variant for error states
  • Removed redundant icon mapping and styling code

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

FileDescription
SelectPanel.tsxReplaced custom notice implementation with Banner component and updated variant mapping
SelectPanel.module.cssUpdated CSS selector to match Banner's 'critical' variant instead of 'error'

Comment threadpackages/react/src/SelectPanel/SelectPanel.tsx Outdated
@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Aug 26, 2025
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@francineluccafrancinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Aug 26, 2025
@github-actions
github-actionsBot requested a deployment to storybook-preview-6669 August 26, 2025 02:25 Abandoned
@github-actions

github-actionsBot commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js88.58 KB (-0.07% 🔽)
packages/react/dist/browser.umd.js88.7 KB (-0.04% 🔽)

@primer
primerBot requested a review from a team as a code ownerAugust 26, 2025 02:33
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Aug 26, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6669 August 26, 2025 02:35 Inactive
…ice' of github.com:primer/react into 5647-bug-info-icon-misalignment-in-selectpanel-with-notice
@github-actions
github-actionsBot requested a deployment to storybook-preview-6669 August 26, 2025 20:34 Abandoned
@francineluccafrancinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Aug 26, 2025
Comment threadpackages/react/src/SelectPanel/SelectPanel.module.css Outdated
@francineluccafrancinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 10, 2025
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 10, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6669 September 10, 2025 16:55 Inactive
@francineluccafrancinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 10, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6669 September 10, 2025 17:08 Inactive
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 10, 2025
@francineluccafrancinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 10, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6669 September 10, 2025 17:22 Inactive
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 10, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6669 September 10, 2025 17:37 Inactive
@francinelucca
francinelucca added this pull request to the merge queueSep 11, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6669 September 11, 2025 21:29 Inactive
Merged via the queue into main with commit 627cc4bSep 11, 2025
43 checks passed
@primerprimerBot mentioned this pull request Sep 11, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpmstaffAuthor is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@francinelucca@hectahertz