Uh oh!
There was an error while loading. Please reload this page.
chore: use Banner instead of custom implementation for SelectPanel notice - #6669
Conversation
🦋 Changeset detectedLatest commit: 8971a92 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the SelectPanel component's notice display to use the reusable Banner component instead of a custom implementation. This change improves code consistency and maintainability by leveraging an existing design system component.
Key Changes
- Replaced custom notice implementation with Banner component from the design system
- Updated variant mapping to handle Banner's 'critical' variant for error states
- Removed redundant icon mapping and styling code
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| SelectPanel.tsx | Replaced custom notice implementation with Banner component and updated variant mapping |
| SelectPanel.module.css | Updated CSS selector to match Banner's 'critical' variant instead of 'error' |
Uh oh!
There was an error while loading. Please reload this page.
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
…ice' of github.com:primer/react into 5647-bug-info-icon-misalignment-in-selectpanel-with-notice
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Closeshttps://github.com/github/primer/issues/5647
Changelog
Changed
BannerRollout strategy
Testing & Reviewing
Merge checklist