Uh oh!
There was an error while loading. Please reload this page.
Change ADR 7 status to abandoned - #6678
Merged
Merged
Conversation
siddharthkp
commented
Aug 27, 2025
Member
- Context: https://github.com/github/primer/issues/2534#issuecomment-3227363552
Updated the status of the 'Adopted' stage to indicate abandonment.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR abandons ADR 7 (Experimental Components) by updating its status from "Adopted" to "Abandoned" with a reference to the decision context.
- Changes the status of ADR 7 from adopted (in progress) to abandoned
- Adds a link to the GitHub issue comment explaining the abandonment decision
Contributor
size-limit report 📦
|
joshblack
approved these changes
Aug 27, 2025
Uh oh!
There was an error while loading. Please reload this page.
10 tasks
janmaarten-a11y added a commit
that referenced
this pull request
Jul 7, 2026
The Dismissal Requested event's live inline template renders a float-right DismissalReviewDialogComponent when show_dismissal_actions is true — its visible control is a single small primary "Review request" button that opens the approve/deny review dialog. Surface it in the Timeline.Actions right-controls slot (#6678) on the Requested variant only. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
janmaarten-a11y added a commit
that referenced
this pull request
Jul 7, 2026
The Dismissal Requested event's live inline template renders a float-right DismissalReviewDialogComponent when show_dismissal_actions is true — its visible control is a single small primary "Review request" button that opens the approve/deny review dialog. Surface it in the Timeline.Actions right-controls slot (#6678) on the Requested variant only. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
janmaarten-a11y added a commit
that referenced
this pull request
Jul 8, 2026
The Dismissal Requested event's live inline template renders a float-right DismissalReviewDialogComponent when show_dismissal_actions is true — its visible control is a single small primary "Review request" button that opens the approve/deny review dialog. Surface it in the Timeline.Actions right-controls slot (#6678) on the Requested variant only. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.