Skip to content

Remove sx prop support from the Token component - #6690

Merged
liuliu-dev merged 24 commits into
mainfrom
liuliu/remove-sx-from-token-component
Sep 30, 2025
Merged

Remove sx prop support from the Token component #6690
liuliu-dev merged 24 commits into
mainfrom
liuliu/remove-sx-from-token-component

Conversation

@liuliu-dev

@liuliu-devliuliu-dev commented Aug 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Wait until this PR is merged in github-ui: https://github.com/github/github-ui/pull/3366

Closes#5813

Need to be careful about the PolymorphicForwardRefComponent type change.

Need to do changes in github-ui since it's still using Token component with sx, tracking here: https://github.com/github/primer/issues/5827
sx usage

Changelog

Removed

Rollout strategy

  • Major release; if selected, include a written rollout or migration plan

@changeset-bot

changeset-botBot commented Aug 28, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: dd53474

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
NameType
@primer/reactMajor
@primer/styled-reactMajor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Aug 28, 2025
@github-actions

github-actionsBot commented Aug 28, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions

github-actionsBot commented Aug 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js87.95 KB (+0.01% 🔺)
packages/react/dist/browser.umd.js88.09 KB (-0.09% 🔽)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-6690 August 28, 2025 23:46 Inactive
@github-actions
github-actionsBot requested a deployment to storybook-preview-6690 September 5, 2025 22:36 Abandoned
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6690 September 5, 2025 22:45 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6690 September 15, 2025 22:54 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6690 September 15, 2025 23:20 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6690 September 15, 2025 23:27 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6690 September 15, 2025 23:36 Inactive
@github-actionsgithub-actionsBot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 16, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6690 September 16, 2025 17:53 Inactive
@github-actionsgithub-actionsBot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 25, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6690 September 25, 2025 21:40 Inactive
@github-actionsgithub-actionsBot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Sep 25, 2025
@francinelucca
francinelucca added this pull request to the merge queueSep 26, 2025
@liuliu-dev
liuliu-dev removed this pull request from the merge queue due to a manual request Sep 26, 2025
@liuliu-devliuliu-dev changed the title Remove sx prop support from the Token component DO NOT MERGE: Remove sx prop support from the Token component Sep 26, 2025
@liuliu-devliuliu-dev changed the title DO NOT MERGE: Remove sx prop support from the Token component Remove sx prop support from the Token component Sep 30, 2025
@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 30, 2025
@github-actions

github-actionsBot commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actionsgithub-actionsBot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh labels Sep 30, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6690 September 30, 2025 20:27 Inactive
@primer-integration

primer-integrationBot commented Sep 30, 2025

Copy link
Copy Markdown

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/3583

@primer-integration

primer-integrationBot commented Sep 30, 2025

Copy link
Copy Markdown

🟢 ci completed with status success.

@github-actionsgithub-actionsBot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Sep 30, 2025
@liuliu-dev
liuliu-dev added this pull request to the merge queueSep 30, 2025
Merged via the queue into main with commit c5c2053Sep 30, 2025
44 checks passed
@liuliu-dev
liuliu-dev deleted the liuliu/remove-sx-from-token-component branch September 30, 2025 21:34
@primerprimerBot mentioned this pull request Sep 30, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@francineluccafrancineluccafrancinelucca approved these changes
@siddharthkpsiddharthkpAwaiting requested review from siddharthkpsiddharthkp is a code owner automatically assigned from primer/engineer-reviewers

Assignees

No one assigned

Labels

integration-tests: passingChanges in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liuliu-dev@francinelucca