chore: add portal context by francinelucca · Pull Request #6815 · primer/react

francinelucca · 2025-09-09T18:27:00Z

This pull request introduces a new PortalContext to the @primer/react library, allowing more flexible and context-driven control over where portal content is rendered. The changes include updates to the core Portal component, its exports, new Storybook examples, and additional tests to ensure correct behavior when using PortalContext and container overrides.

Changelog

New

Added PortalContext to Portal.tsx, allowing consumers to specify a portalContainerName via React context, which determines the portal root container for content rendering. The Portal component now prioritizes the context value unless overridden by its own containerName prop.
Added new tests in Portal.test.tsx to verify correct portal rendering behavior when using PortalContext, including context-only, default fallback, undefined context, and prop override scenarios.
Added a Storybook example (WithPortalContext) in Portal.features.stories.tsx to demonstrate how to use PortalContext for controlling portal rendering, including context and prop override cases.

Changed

Updated exports in index.ts and the package entry point to include PortalContext, making it available for consumers.

Removed

Rollout strategy

Patch release
Minor release
Major release; if selected, include a written rollout or migration plan
None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Added/updated tests
Added/updated documentation
Added/updated previews (Storybook)
Changes are SSR compatible
Tested in Chrome
Tested in Firefox
Tested in Safari
Tested in Edge
(GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

changeset-bot · 2025-09-09T18:27:04Z

🦋 Changeset detected

Latest commit: 1884fcc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@primer/react	Minor
@primer/styled-react	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2025-09-09T18:27:38Z

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

francinelucca · 2025-09-09T18:30:51Z

@copilot add tests to ensure elements render correctly inside custom Portal when PortalContext is supplied and on the default otherwise

Copilot · 2025-09-09T18:31:00Z

@francinelucca I've opened a new pull request, #6816, to work on those changes. Once the pull request is ready, I'll request review from you.

github-actions · 2025-09-09T18:31:20Z

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	89.62 KB (+0.11% 🔺)
packages/react/dist/browser.umd.js	89.56 KB (-0.06% 🔽)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>

francinelucca · 2025-09-09T23:27:16Z

@copilot add a storybook story that demonstrates how to use PortalContext to render items within a different Portal than the default

Copilot · 2025-09-09T23:27:25Z

@francinelucca I've opened a new pull request, #6821, to work on those changes. Once the pull request is ready, I'll request review from you.

…#6821) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com> Co-authored-by: Marie Lucca <francinelucca@github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions · 2025-09-11T21:06:09Z

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

francinelucca · 2025-09-12T17:35:06Z

@copilot fix the accessibility issue with the dark theme by using token background colors from the theme

Copilot · 2025-09-12T17:35:15Z

@francinelucca I've opened a new pull request, #6847, to work on those changes. Once the pull request is ready, I'll request review from you.

…ckground colors (#6847) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>

github-actions · 2025-09-12T18:23:53Z

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

github-actions · 2025-09-12T18:24:08Z

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Adam Dierkens <adierkens@users.noreply.github.com>

chore: add portal context
d562130

github-actionsBot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 9, 2025

CopilotAI mentioned this pull request Sep 9, 2025
chore: add portal context with comprehensive tests #6816
Merged
13 tasks

francineluccaand others added 2 commits September 9, 2025 14:32

fix rule of hooks
9f4bc0e

Merge branch 'main' into chore/add-portal-context
ef1df23

github-actionsBottemporarily deployed to storybook-preview-6815 September 9, 2025 18:51 Inactive

francinelucca deployed to github-pages September 9, 2025 19:08 — with GitHub Actions View deployment

github-actionsBottemporarily deployed to storybook-preview-6815 September 9, 2025 19:09 Inactive

chore: add portal context with comprehensive tests (#6816)
b221f84
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>

CopilotAI mentioned this pull request Sep 9, 2025
chore: add portal context with comprehensive tests and storybook demo #6821
Merged
13 tasks

francinelucca had a problem deploying to github-pages September 9, 2025 23:28 — with GitHub Actions Failure

github-actionsBot requested a deployment to storybook-preview-6815 September 9, 2025 23:29 Abandoned

CopilotAIand others added 2 commits September 10, 2025 10:14

Update version for @primer/react and rename context
ebfc648

francinelucca marked this pull request as ready for review September 10, 2025 14:18

CopilotAI review requested due to automatic review settings September 10, 2025 14:18

francinelucca requested a review from a team as a code owner September 10, 2025 14:18

francinelucca requested review from adierkens and joshblack September 10, 2025 14:18

github-actionsBot requested a deployment to storybook-preview-6815 September 10, 2025 14:19 Abandoned

This comment was marked as outdated.
Sign in to view

Update packages/react/src/Portal/Portal.tsx
de1e26e
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

francinelucca deployed to github-pages September 11, 2025 15:09 — with GitHub Actions View deployment

github-actionsBottemporarily deployed to storybook-preview-6815 September 11, 2025 15:09 Inactive

Merge branch 'main' into chore/add-portal-context
56d483c

github-actionsBot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 11, 2025

francinelucca deployed to github-pages September 11, 2025 21:13 — with GitHub Actions View deployment

github-actionsBottemporarily deployed to storybook-preview-6815 September 11, 2025 21:14 Inactive

francinelucca deployed to github-pages September 11, 2025 21:31 — with GitHub Actions View deployment

github-actionsBottemporarily deployed to storybook-preview-6815 September 11, 2025 21:31 Inactive

CopilotAI mentioned this pull request Sep 12, 2025
[WIP] fix: address accessibility issue with dark theme using token background colors #6847
Merged
13 tasks

github-actionsBot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 12, 2025

CopilotAIand others added 2 commits September 12, 2025 14:23

[WIP] fix: address accessibility issue with dark theme using token ba…
4ad5155
…ckground colors (#6847) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>

Merge branch 'main' into chore/add-portal-context
1884fcc

github-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 12, 2025

github-actionsBot requested a deployment to storybook-preview-6815 September 12, 2025 18:26 Abandoned

francinelucca deployed to github-pages September 12, 2025 18:34 — with GitHub Actions View deployment

github-actionsBottemporarily deployed to storybook-preview-6815 September 12, 2025 18:35 Inactive

francinelucca added this pull request to the merge queue Sep 12, 2025

github-merge-queueBot removed this pull request from the merge queue due to failed status checks Sep 12, 2025

francinelucca added this pull request to the merge queue Sep 12, 2025

Merged via the queue into main with commit 2024709Sep 12, 2025
43 checks passed

francinelucca deleted the chore/add-portal-context branch September 12, 2025 21:58

primerBot mentioned this pull request Sep 12, 2025
Release tracking (rc) #6842
Merged

Uh oh!

Conversation

francinelucca commented Sep 9, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

New

Changed

Removed

Rollout strategy

Testing & Reviewing

Merge checklist

Uh oh!

changeset-botBot commented Sep 9, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actionsBot commented Sep 9, 2025

Uh oh!

francinelucca commented Sep 9, 2025

Uh oh!

CopilotAI commented Sep 9, 2025

Uh oh!

github-actionsBot commented Sep 9, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

francinelucca commented Sep 9, 2025

Uh oh!

CopilotAI commented Sep 9, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actionsBot commented Sep 11, 2025

Uh oh!

francinelucca commented Sep 12, 2025

Uh oh!

CopilotAI commented Sep 12, 2025

Uh oh!

github-actionsBot commented Sep 12, 2025

Uh oh!

github-actionsBot commented Sep 12, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

francinelucca commented Sep 9, 2025•
edited
Loading

changeset-botBot commented Sep 9, 2025•
edited
Loading

github-actionsBot commented Sep 9, 2025•
edited
Loading