Uh oh!
There was an error while loading. Please reload this page.
feat: remove sx prop from Button, LinkButton, IconButton, and ButtonG… - #6828
Closed
joshblack wants to merge 1 commit into
Closed
feat: remove sx prop from Button, LinkButton, IconButton, and ButtonG…#6828joshblack wants to merge 1 commit into
joshblack wants to merge 1 commit into
Conversation
|
Contributor
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
janmaarten-a11y added a commit
that referenced
this pull request
Jul 7, 2026
…nts to Private/ namespace
Add packages/react/src/Timeline/internal/timelineStoryHelpers.{tsx,module.css}
with six story-only helpers (VariantSection, RealisticTimeline, Examples,
BoldLink, InlineAvatar, MutedTime) for the Timeline event-story surfaces to
share. Never exported from the package index (stories don't ship), so no public
API surface. BoldLink/InlineAvatar/MutedTime shim live-GitHub styling Primer
doesn't express yet (tracked in github/primer#6826/#6827/#6828).
Retitle the Comments stories to Private/Components/Timeline/Events/Comments and
consume the shared VariantSection + RealisticTimeline. Pure refactor — Storybook
rendering unchanged.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>janmaarten-a11y added a commit
that referenced
this pull request
Jul 7, 2026
Swap the Code Scanning story's local scaffolding for the shared internal helpers in ./internal/timelineStoryHelpers: VariantSection (captioned section), Examples / RealisticTimeline (wrappers), BoldLink (#6826), InlineAvatar (#6827), and MutedTime (#6828). EventFixed has no in-text links, so it uses the no-links RealisticTimeline wrapper; the link-bearing groups keep Examples. Delete the now-duplicated local classes (.Variant, .VariantLabel, .RealisticTimeline, .LinkWithBoldStyle, .InlineAvatar, .Timestamp). Pure refactor — no rendered output change; the workflow sub-row icon label and tool-version Label are untouched. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
janmaarten-a11y added a commit
that referenced
this pull request
Jul 7, 2026
…nts to Private/ namespace
Add packages/react/src/Timeline/internal/timelineStoryHelpers.{tsx,module.css}
with six story-only helpers (VariantSection, RealisticTimeline, Examples,
BoldLink, InlineAvatar, MutedTime) for the Timeline event-story surfaces to
share. Never exported from the package index (stories don't ship), so no public
API surface. BoldLink/InlineAvatar/MutedTime shim live-GitHub styling Primer
doesn't express yet (tracked in github/primer#6826/#6827/#6828).
Retitle the Comments stories to Private/Components/Timeline/Events/Comments and
consume the shared VariantSection + RealisticTimeline. Pure refactor — Storybook
rendering unchanged.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>janmaarten-a11y added a commit
that referenced
this pull request
Jul 7, 2026
Swap the Code Scanning story's local scaffolding for the shared internal helpers in ./internal/timelineStoryHelpers: VariantSection (captioned section), Examples / RealisticTimeline (wrappers), BoldLink (#6826), InlineAvatar (#6827), and MutedTime (#6828). EventFixed has no in-text links, so it uses the no-links RealisticTimeline wrapper; the link-bearing groups keep Examples. Delete the now-duplicated local classes (.Variant, .VariantLabel, .RealisticTimeline, .LinkWithBoldStyle, .InlineAvatar, .Timestamp). Pure refactor — no rendered output change; the workflow sub-row icon label and tool-version Label are untouched. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
10 tasks
janmaarten-a11y added a commit
that referenced
this pull request
Jul 8, 2026
Swap the Code Scanning story's local scaffolding for the shared internal helpers in ./internal/timelineStoryHelpers: VariantSection (captioned section), Examples / RealisticTimeline (wrappers), BoldLink (#6826), InlineAvatar (#6827), and MutedTime (#6828). EventFixed has no in-text links, so it uses the no-links RealisticTimeline wrapper; the link-bearing groups keep Examples. Delete the now-duplicated local classes (.Variant, .VariantLabel, .RealisticTimeline, .LinkWithBoldStyle, .InlineAvatar, .Timestamp). Pure refactor — no rendered output change; the workflow sub-row icon label and tool-version Label are untouched. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
janmaarten-a11y added a commit
that referenced
this pull request
Jul 8, 2026
Swap the Code Scanning story's local scaffolding for the shared internal helpers in ./internal/timelineStoryHelpers: VariantSection (captioned section), Examples / RealisticTimeline (wrappers), BoldLink (#6826), InlineAvatar (#6827), and MutedTime (#6828). EventFixed has no in-text links, so it uses the no-links RealisticTimeline wrapper; the link-bearing groups keep Examples. Delete the now-duplicated local classes (.Variant, .VariantLabel, .RealisticTimeline, .LinkWithBoldStyle, .InlineAvatar, .Timestamp). Pure refactor — no rendered output change; the workflow sub-row icon label and tool-version Label are untouched. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…roup
Closes #
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist