Skip to content

chore: fix ActionBar gap issue#6829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francinelucca merged 10 commits into from
Sep 22, 2025
Merged

chore: fix ActionBar gap issue #6829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8363365
chore: fix ActionBar gap issue
francinelucca Sep 10, 2025
68ab1cb
Fix ActionBar gap issue in changeset
francinelucca Sep 11, 2025
07d120a
Merge branch 'main' into chore/fix-actionbar-gap-issue
francinelucca Sep 11, 2025
9a0d93d
Merge branch 'main' into chore/fix-actionbar-gap-issue
francinelucca Sep 12, 2025
cfb2c90
Merge branch 'main' into chore/fix-actionbar-gap-issue
hectahertz Sep 12, 2025
e687d0f
Merge branch 'main' into chore/fix-actionbar-gap-issue
francinelucca Sep 12, 2025
b6327d8
Merge branch 'main' into chore/fix-actionbar-gap-issue
francinelucca Sep 17, 2025
1977bed
fix spacing issues
francinelucca Sep 18, 2025
cb90f5a
test(vrt): update snapshots
francinelucca Sep 18, 2025
c46bcce
Revert "test(vrt): update snapshots"
francinelucca Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/chilly-dingos-build.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

chore: fix ActionBar gap issue
8 changes: 5 additions & 3 deletions packages/react/src/ActionBar/ActionBar.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,8 @@ import {useFocusZone, FocusKeys} from '../hooks/useFocusZone'
import styles from './ActionBar.module.css'
import {clsx} from 'clsx'

const ACTIONBAR_ITEM_GAP = 8

type ChildSize = {
text: string
width: number
Expand DownExpand Up@@ -48,7 +50,7 @@ export type ActionBarProps = {

export type ActionBarIconButtonProps = {disabled?: boolean} & IconButtonProps

const MORE_BTN_WIDTH = 86
const MORE_BTN_WIDTH = 32

const getValidChildren = (children: React.ReactNode) => {
return React.Children.toArray(children).filter(child => {
Expand All@@ -61,7 +63,7 @@ const calculatePossibleItems = (childWidthArray: ChildWidthArray, navWidth: numb
let breakpoint = childWidthArray.length // assume all items will fit
let sumsOfChildWidth = 0
for (const [index, childWidth] of childWidthArray.entries()) {
sumsOfChildWidth = sumsOfChildWidth + childWidth.width // + GAP
sumsOfChildWidth += index > 0 ? childWidth.width + ACTIONBAR_ITEM_GAP : childWidth.width
if (sumsOfChildWidth > widthToFit) {
breakpoint = index
break
Expand DownExpand Up@@ -202,7 +204,7 @@ export const ActionBar: React.FC<React.PropsWithChildren<ActionBarProps>> = prop
return (
<ActionBarContext.Provider value={{size, setChildrenWidth}}>
<div ref={navRef} className={clsx(className, styles.Nav)} data-flush={flush}>
<div ref={listRef} role="toolbar" className={styles.List}>
<div ref={listRef} role="toolbar" className={styles.List} style={{gap: `${ACTIONBAR_ITEM_GAP}px`}}>

CopilotAISep 11, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Inline styles should be avoided in favor of CSS classes. Consider adding the gap value to the CSS module file instead of using inline styles.

Copilot uses AI. Check for mistakes.
{listItems}
{menuItems.length > 0 && (
<ActionMenu>
Expand Down
Loading