Skip to content

Remove Banner from experimental - #6863

Merged
pksjce merged 4 commits into
mainfrom
pk/remove-banner-experimental
Sep 22, 2025
Merged

Remove Banner from experimental#6863
pksjce merged 4 commits into
mainfrom
pk/remove-banner-experimental

Conversation

@pksjce

Copy link
Copy Markdown
Contributor

Closes #https://github.com/github/primer/issues/5628

Changelog

Once this https://github.com/github/github-ui/pull/2576 gets merged, we won't have any more references for Banner from @primer/react/experimental

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@pksjce
pksjce requested a review from a team as a code ownerSeptember 17, 2025 00:08
@changeset-bot

changeset-botBot commented Sep 17, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9d28ef6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
NameType
@primer/reactMajor
@primer/styled-reactMajor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the Banner component from the experimental exports, moving it from experimental to stable API status. This is part of the component's graduation process once external references are cleaned up.

  • Removes Banner and BannerProps exports from the experimental index
  • Updates test snapshots to reflect the removed experimental exports

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

FileDescription
packages/react/src/experimental/index.tsRemoves Banner component and type exports from experimental namespace
packages/react/src/tests/snapshots/exports.test.ts.snapUpdates snapshot to reflect removal of Banner from experimental exports

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 17, 2025
@github-actions
github-actionsBot requested a deployment to storybook-preview-6863 September 17, 2025 00:12 Abandoned
@pksjce

Copy link
Copy Markdown
ContributorAuthor

We have zero instances of Banner from @primer/react/experimental on github-ui 👍 This one is also ready to merge

@pksjce
pksjce enabled auto-merge September 17, 2025 23:22
@pksjce
pksjce added this pull request to the merge queueSep 22, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6863 September 22, 2025 17:32 Inactive
Merged via the queue into main with commit 9614c0eSep 22, 2025
40 of 41 checks passed
@pksjce
pksjce deleted the pk/remove-banner-experimental branch September 22, 2025 17:40
@primerprimerBot mentioned this pull request Sep 22, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@pksjce@siddharthkp@jonrohan