chore(LinkButton): remove sx from LinkButton

[francinelucca]

Closes#6767

Remove sx from the LinkButton component

Current sx usage: 0

✅ Don't need to separately update github-ui components to use @primer/styled-react

Changelog

Changed

• LinkButton export in @primer/styled-react to support removed sx prop

Removed

• sx prop from LinkButton

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

[changeset-bot]

🦋 Changeset detected

Latest commit: 9dbbe29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@primer/react	Major
@primer/styled-react	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

[primer-integration]

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/2883

[primer-integration]

🟢 ci completed with status success.

[Copilot]

Pull Request Overview

Purpose: Remove the sx prop from @primer/react's LinkButton (breaking change) while preserving backward compatibility for styled-system consumers via a styled-react wrapper that reintroduces sx support.

Key changes:

• Removed sx handling from LinkButton implementation in @primer/react and updated its exported prop types.
• Added a styled-react LinkButton wrapper that reattaches sx via styled-components.
• Updated exports, snapshot, story usage, and added a changeset marking a major release.

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/styled-react/src/index.tsx	Re-exports custom styled-react LinkButton with sx support and its props.
packages/styled-react/src/components/LinkButton.tsx	Introduces styled-components wrapper to reintroduce sx prop.
packages/react/src/Button/LinkButton.tsx	Removes sx prop from core LinkButton implementation.
packages/react/src/Button/index.ts	Exports new LinkButtonProps type.
packages/react/src/tests/snapshots/exports.test.ts.snap	Updates snapshot to include new exported type.
packages/react/src/ButtonGroup/ButtonGroup.dev.stories.tsx	Replaces deprecated sx usage with inline style in story.
eslint.config.mjs	Adjusts ignore path for polymorphic helper filename change.
.changeset/stale-avocados-enjoy.md	Declares semver impact (major/minor) for the change.

[Copilot]

The styled wrapper forwards the sx prop directly to PrimerLinkButton, which no longer declares or consumes sx; PrimerLinkButton spreads remaining props to ButtonBase, risking an invalid sx attribute reaching the DOM (e.g., ). Filter out sx before forwarding: either use withConfig({shouldForwardProp: prop => prop !== 'sx'}) or wrap the inner component: const LinkButton = styled(({sx, ...rest}) => <PrimerLinkButton {...rest} />)${sx} to prevent leaking sx to the DOM.

Suggested change

	constLinkButton: ForwardRefComponent<'a',LinkButtonProps>=styled(PrimerLinkButton)<LinkButtonProps>`
	constLinkButton: ForwardRefComponent<'a',LinkButtonProps>=styled(({sx, ...rest})=><PrimerLinkButton{...rest}/>)<LinkButtonProps>`

[github-actions]

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!