Skip to content

export textprops - #6901

Merged
TylerJDev merged 2 commits into
mainfrom
liuliu/export-text-props
Sep 23, 2025
Merged

export textprops#6901
TylerJDev merged 2 commits into
mainfrom
liuliu/export-text-props

Conversation

@liuliu-dev

Copy link
Copy Markdown
Contributor

Export the TextProps type which is used in github-ui with sx props here: https://github.com/github/github-ui/blob/32e09224eeff26992946d2c380f1fe43c6d1c179/app/assets/modules/react-shared/Count.tsx#L9

Rollout strategy

  • Patch release

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e80883b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/styled-reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@liuliu-dev
liuliu-dev marked this pull request as ready for review September 23, 2025 21:03
@liuliu-dev
liuliu-dev requested a review from a team as a code ownerSeptember 23, 2025 21:03

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR exports the TextProps type from the @primer/styled-react package to make it available for external consumption, specifically for use in github-ui.

Key Changes

  • Export the TextProps type interface from the styled-react package
  • Add changeset documentation for the patch release

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

FileDescription
packages/styled-react/src/index.tsxAdds export for TextProps type alongside existing Text component export
.changeset/shiny-deer-lose.mdDocuments the change for version release tracking

@github-actions
github-actionsBottemporarily deployed to storybook-preview-6901 September 23, 2025 21:12 Inactive
@TylerJDev
TylerJDev merged commit e6e2f8b into mainSep 23, 2025
46 checks passed
@TylerJDev
TylerJDev deleted the liuliu/export-text-props branch September 23, 2025 21:31
@primerprimerBot mentioned this pull request Sep 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@liuliu-dev@francinelucca@TylerJDev