Skip to content

Adjust text-decoration-offset for Link component - #6927

Merged
lukasoppermann merged 6 commits into
mainfrom
@lukasoppermann/link-underline
Oct 1, 2025
Merged

Adjust text-decoration-offset for Link component#6927
lukasoppermann merged 6 commits into
mainfrom
@lukasoppermann/link-underline

Conversation

@lukasoppermann

Copy link
Copy Markdown
Contributor

Closes # https://github.com/github/primer/issues/5933#issuecomment-3352390446

Changelog

This reduced the distance of the link underline.

BeforeAfter
CleanShot 2025-09-30 at 21 31 59@2xCleanShot 2025-09-30 at 21 32 25@2x

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot

changeset-botBot commented Sep 30, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 500e393

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
NameType
@primer/reactPatch
@primer/styled-reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

Uh oh! @lukasoppermann, at least one image you shared is missing helpful alt text. Check your pull request body to fix the following violations:

  • Images should have meaningful alternative text (alt text) at line 12
  • Images should have meaningful alternative text (alt text) at line 12
  • Images should have meaningful alternative text (alt text) at line 12
  • Images should have meaningful alternative text (alt text) at line 12

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adjusts the underline positioning for the Link component by adding a text-underline-offset property to bring the underline closer to the text. The change reduces the distance between text and its decorative underline for improved visual appearance.

Key Changes:

  • Added text-underline-offset: 0.1rem to the Link component's CSS module
  • Included changeset documentation for a patch release

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

FileDescription
packages/react/src/Link/Link.module.cssAdds text-underline-offset property to reduce underline distance
.changeset/tender-dodos-create.mdDocuments the change for patch release versioning

Comment threadpackages/react/src/Link/Link.module.css Outdated
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 30, 2025
@siddharthkpsiddharthkp added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 1, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6927 October 1, 2025 07:10 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6927 October 1, 2025 07:27 Inactive
@lukasoppermannlukasoppermann added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Oct 1, 2025
@primer
primerBot requested a review from a team as a code ownerOctober 1, 2025 07:39
@primer
primerBot requested a review from mperrottiOctober 1, 2025 07:39
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 1, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6927 October 1, 2025 07:49 Inactive
Comment thread.changeset/tender-dodos-create.md Outdated
Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6927 October 1, 2025 11:42 Inactive
@lukasoppermann
lukasoppermann added this pull request to the merge queueOct 1, 2025
Merged via the queue into main with commit 913739dOct 1, 2025
40 of 42 checks passed
@lukasoppermann
lukasoppermann deleted the @lukasoppermann/link-underline branch October 1, 2025 11:51
@primerprimerBot mentioned this pull request Oct 1, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lukasoppermann@siddharthkp