Skip to content

Revert "Remove support for sx from BaseStyles component" - #6934

Closed
jonrohan wants to merge 1 commit into
mainfrom
revert-6878-llastflowers/6758/no-sx-BaseStyles
Closed

Revert "Remove support for sx from BaseStyles component"#6934
jonrohan wants to merge 1 commit into
mainfrom
revert-6878-llastflowers/6758/no-sx-BaseStyles

Conversation

@jonrohan

Copy link
Copy Markdown
Member

Reverts #6878

@jonrohan
jonrohan requested a review from a team as a code ownerOctober 1, 2025 18:40
CopilotAI review requested due to automatic review settings October 1, 2025 18:40
@jonrohan
jonrohan requested a review from a team as a code ownerOctober 1, 2025 18:40
@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8999c87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the removal of sx prop support from the BaseStyles component, restoring its ability to accept system props and sx styling. This is a breaking change reversion that brings back previously removed functionality.

  • Restores sx prop support to BaseStyles component type definitions
  • Re-implements BoxWithFallback wrapper to enable system props handling
  • Adds comprehensive test coverage for the restored functionality

Reviewed Changes

Copilot reviewed 5 out of 23 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
packages/react/src/BaseStyles.tsxRestores SxProp type and BoxWithFallback wrapper implementation
packages/react/src/tests/BaseStyles.test.tsxAdds unit test for system props functionality
packages/react/src/BaseStyles.dev.stories.tsxAdds Storybook examples demonstrating sx and system props usage
e2e/components/BaseStyles.test.tsUpdates e2e test configuration to include new story variants
.changeset/sharp-beans-run.mdRemoves the changeset entry for the original breaking change

@github-actionsgithub-actionsBot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 1, 2025
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@primer-integration

Copy link
Copy Markdown

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/3651

@primer-integration

Copy link
Copy Markdown

🔴 ci completed with status failure.

@github-actionsgithub-actionsBot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 1, 2025
@jonrohanjonrohan closed this Oct 1, 2025
@jonrohan
jonrohan deleted the revert-6878-llastflowers/6758/no-sx-BaseStyles branch October 30, 2025 20:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: failingChanges in this PR cause breaking changes in gh/ghstaffAuthor is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jonrohan