Skip to content

Adjust ConfirmationDialog heading styling - #6954

Merged
langermank merged 4 commits into
mainfrom
confirmation-dialog-heading
Oct 6, 2025
Merged

Adjust ConfirmationDialog heading styling#6954
langermank merged 4 commits into
mainfrom
confirmation-dialog-heading

Conversation

@langermank

Copy link
Copy Markdown
Contributor

Closeshttps://github.com/github/primer/issues/4257

beforeafter
Old titleUpdated title

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@langermank
langermank requested a review from a team as a code ownerOctober 6, 2025 20:28
@changeset-bot

changeset-botBot commented Oct 6, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 68cf909

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
NameType
@primer/reactPatch
@primer/styled-reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the ConfirmationDialog component's heading styling by replacing the custom-styled <h1> element with the design system's Heading component to ensure consistent typography across the application.

Key changes:

  • Import and use the Heading component instead of plain <h1>
  • Remove custom CSS styles for the heading element
  • Apply "small" variant to the Heading component for consistent sizing

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

FileDescription
packages/react/src/ConfirmationDialog/ConfirmationDialog.tsxReplaces custom <h1> with Heading component using "small" variant
packages/react/src/ConfirmationDialog/ConfirmationDialog.module.cssRemoves custom font-size, font-weight, and margin styles for h1 element

@@ -5,11 +5,6 @@

> h1 {

CopilotAIOct 6, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS selector > h1 may not match the new Heading component structure. Consider updating the selector to target the actual rendered element or use a more generic approach to ensure the padding and flex-grow styles are properly applied.

Suggested change
>h1 {
>* {

Copilot uses AI. Check for mistakes.
@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 6, 2025
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
github-actionsBot requested a deployment to storybook-preview-6954 October 6, 2025 20:32 Abandoned
@langermanklangermank added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 6, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6954 October 6, 2025 20:40 Inactive
@primer
primerBot requested a review from a team as a code ownerOctober 6, 2025 20:48
@primer
primerBot requested a review from mperrottiOctober 6, 2025 20:48
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 6, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6954 October 6, 2025 20:57 Inactive
@langermank
langermank added this pull request to the merge queueOct 6, 2025
Merged via the queue into main with commit 7dd483fOct 6, 2025
42 checks passed
@langermank
langermank deleted the confirmation-dialog-heading branch October 6, 2025 21:52
@primerprimerBot mentioned this pull request Oct 6, 2025
pksjce pushed a commit that referenced this pull request Oct 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@langermank@jonrohan